Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 896133005: Plugin Power Saver: Implement UI by Chrome designers. (Closed)

Created:
5 years, 10 months ago by tommycli
Modified:
5 years, 10 months ago
CC:
chromium-reviews, Sebastien Gabriel, Bernhard Bauer
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plugin Power Saver: Implement UI by Chrome designers. This patch: a) Implements the new UI by our Chrome designers for PPS. b) No longer tiles the poster image in case it's the wrong size. Now it centers and 'contain's it. BUG=443810, 403800 Committed: https://crrev.com/8543891ac05c45e247da267d43d8926bafc1c95f Cr-Commit-Position: refs/heads/master@{#315601}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Designer requests hover on icon only. bauerb requests some code cleanups. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -9 lines) Patch
M chrome/renderer/resources/plugin_poster.html View 1 1 chunk +22 lines, -9 lines 0 comments Download
A chrome/renderer/resources/plugin_power_saver_play.png View Binary file 0 comments Download

Messages

Total messages: 14 (5 generated)
tommycli
thestig: ptal This is a video of what it looks like: https://drive.google.com/open?id=0B-Use9bxumRNQnBDZFhsZUZBMlk
5 years, 10 months ago (2015-02-10 00:04:55 UTC) #3
tommycli
thestig: Sebastien Gabriel is the designer. I also linked the video to him.
5 years, 10 months ago (2015-02-10 00:05:20 UTC) #4
tommycli
bauerb: Designer asked me to consider some CSS transitions on the opacity. I noticed that ...
5 years, 10 months ago (2015-02-10 02:31:11 UTC) #5
Lei Zhang
If Sebastien is happy with tihs, then lgtm.
5 years, 10 months ago (2015-02-10 03:31:10 UTC) #6
Bernhard Bauer
LGTM with some opportunities to clean up my messes below: (No idea about the animations, ...
5 years, 10 months ago (2015-02-10 09:08:16 UTC) #8
tommycli
bauerb: Thanks! https://codereview.chromium.org/896133005/diff/1/chrome/renderer/resources/plugin_poster.html File chrome/renderer/resources/plugin_poster.html (right): https://codereview.chromium.org/896133005/diff/1/chrome/renderer/resources/plugin_poster.html#newcode44 chrome/renderer/resources/plugin_poster.html:44: <div i18n-values="title:name;.style.background-image:background" id="outer" onclick="plugin.load()"> On 2015/02/10 09:08:16, ...
5 years, 10 months ago (2015-02-10 17:56:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896133005/20001
5 years, 10 months ago (2015-02-10 18:01:36 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-10 18:50:25 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-10 18:51:34 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8543891ac05c45e247da267d43d8926bafc1c95f
Cr-Commit-Position: refs/heads/master@{#315601}

Powered by Google App Engine
This is Rietveld 408576698