Fix Dartium DEBUG failures by ensuring proper scoping within GC prologue/epilogue.

runtime/vm/gc_marker.cc

Index: runtime/vm/gc_marker.cc
===================================================================
--- runtime/vm/gc_marker.cc	(revision 43504)
+++ runtime/vm/gc_marker.cc	(working copy)
@@ -501,19 +501,23 @@
                            bool invoke_api_callbacks,
                            bool collect_code) {
   const bool visit_function_code = !collect_code;
-  MarkingStack marking_stack;
   Prologue(isolate, invoke_api_callbacks);
-  MarkingVisitor mark(
-      isolate, heap_, page_space, &marking_stack, visit_function_code);
-  IterateRoots(isolate, &mark, !invoke_api_callbacks);
-  DrainMarkingStack(isolate, &mark);
-  IterateWeakReferences(isolate, &mark);
-  MarkingWeakVisitor mark_weak;
-  IterateWeakRoots(isolate, &mark_weak, invoke_api_callbacks);
-  mark.Finalize();
-  ProcessWeakTables(page_space);
-  ProcessObjectIdTable(isolate);
-
+  // The API prologue/epilogue may create/destroy zones, so ensure that
+  // anything allocating from the current zone, such as MarkingVisitor, is
+  // destroyed before the epilogue callback.
+  {

[siva, 2015/02/05 23:53:06]

maybe we should start our own zone here.

[koda, 2015/02/06 00:16:07]

Done.

+    MarkingStack marking_stack;
+    MarkingVisitor mark(
+        isolate, heap_, page_space, &marking_stack, visit_function_code);
+    IterateRoots(isolate, &mark, !invoke_api_callbacks);
+    DrainMarkingStack(isolate, &mark);
+    IterateWeakReferences(isolate, &mark);
+    MarkingWeakVisitor mark_weak;
+    IterateWeakRoots(isolate, &mark_weak, invoke_api_callbacks);
+    mark.Finalize();
+    ProcessWeakTables(page_space);
+    ProcessObjectIdTable(isolate);
+  }
   Epilogue(isolate, invoke_api_callbacks);
 }