Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: components/history/core/browser/visit_tracker_unittest.cc

Issue 896093004: Cleanup usage of history namespace in components/history (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/history/core/browser/visit_tracker_unittest.cc
diff --git a/components/history/core/browser/visit_tracker_unittest.cc b/components/history/core/browser/visit_tracker_unittest.cc
index 4f37768d318718964a47bb1c733090100594f273..eee8b9c7d637fffb067a01d58feb2ccc184dab89 100644
--- a/components/history/core/browser/visit_tracker_unittest.cc
+++ b/components/history/core/browser/visit_tracker_unittest.cc
@@ -7,9 +7,7 @@
#include "base/basictypes.h"
#include "testing/gtest/include/gtest/gtest.h"
-using history::ContextID;
-using history::VisitTracker;
-
+namespace history {
namespace {
struct VisitToTest {
@@ -19,13 +17,13 @@ struct VisitToTest {
// Used when adding this to the tracker
const char* url;
- const history::VisitID visit_id;
+ const VisitID visit_id;
// Used when finding the referrer
const char* referrer;
// the correct referring visit ID to compare to the computed one
- history::VisitID referring_visit_id;
+ VisitID referring_visit_id;
};
void RunTest(VisitTracker* tracker, VisitToTest* test, int test_count) {
@@ -35,8 +33,8 @@ void RunTest(VisitTracker* tracker, VisitToTest* test, int test_count) {
ContextID context_id = reinterpret_cast<ContextID>(test[i].context_id_int);
// Check the referrer for this visit.
- history::VisitID ref_visit = tracker->GetLastVisit(
- context_id, test[i].nav_entry_id, GURL(test[i].referrer));
+ VisitID ref_visit = tracker->GetLastVisit(context_id, test[i].nav_entry_id,
+ GURL(test[i].referrer));
EXPECT_EQ(test[i].referring_visit_id, ref_visit);
// Now add this visit.
@@ -128,3 +126,5 @@ TEST(VisitTracker, ProcessRemove) {
};
RunTest(&tracker, part2, arraysize(part2));
}
+
+} // namespace history
« no previous file with comments | « components/history/core/browser/visit_database.cc ('k') | components/history/core/browser/visitsegment_database.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698