Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 896093004: Cleanup usage of history namespace in components/history (Closed)

Created:
5 years, 10 months ago by sdefresne
Modified:
5 years, 10 months ago
CC:
browser-components-watch_chromium.org, chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, pedrosimonetti+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup usage of history namespace in components/history Move PageUsageData from the global namespace to the history namespace, fix forward-declarations, removing old unused ones. Remove unnecessary history:: prefix to refer to names in the history namespace from the code in the history namespace itself. Move anonymous namespace in implementation files as sub-namespace of the history namespace so that they can refer to name in history without using the history:: prefix. BUG=None TBR=dbeam@chromium.org TBR=jhawkins@chromium.org Committed: https://crrev.com/dfd044a845d0950b41b70c62aba0d174ef4b8c1a Cr-Commit-Position: refs/heads/master@{#315003}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -86 lines) Patch
M chrome/browser/history/history_service.h View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/jumplist_win.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/history_menu_bridge.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/most_visited_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/suggestions_page_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/history/core/browser/history_types.h View 4 chunks +4 lines, -5 lines 0 comments Download
M components/history/core/browser/history_types.cc View 1 chunk +19 lines, -20 lines 0 comments Download
M components/history/core/browser/in_memory_url_index_types.h View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/in_memory_url_index_types_unittest.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M components/history/core/browser/page_usage_data.h View 3 chunks +8 lines, -6 lines 0 comments Download
M components/history/core/browser/page_usage_data.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M components/history/core/browser/thumbnail_database.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/history/core/browser/top_sites_database.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M components/history/core/browser/top_sites_observer.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/history/core/browser/url_database.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/history/core/browser/url_database.cc View 8 chunks +9 lines, -11 lines 0 comments Download
M components/history/core/browser/visit_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/visit_tracker_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M components/history/core/browser/visitsegment_database.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
sdefresne
Please take a look.
5 years, 10 months ago (2015-02-05 15:45:41 UTC) #2
droger
lgtm
5 years, 10 months ago (2015-02-05 16:09:45 UTC) #3
sdefresne
TBR-ing OWNERS of impacted code since changes are mechanical dbeam for //chrome/browser/ui/webui jhawkins for //chrome/browser/jumplist_win.h ...
5 years, 10 months ago (2015-02-06 10:40:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896093004/1
5 years, 10 months ago (2015-02-06 10:41:09 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 12:12:28 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/dfd044a845d0950b41b70c62aba0d174ef4b8c1a Cr-Commit-Position: refs/heads/master@{#315003}
5 years, 10 months ago (2015-02-06 12:13:49 UTC) #9
James Hawkins
5 years, 10 months ago (2015-02-06 15:12:34 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698