Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 896093002: sandbox: move SyscallSet into bpf_dsl (Closed)

Created:
5 years, 10 months ago by mdempsky
Modified:
5 years, 10 months ago
CC:
chromium-reviews, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@sandbox-deps
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

sandbox: move SyscallSet into bpf_dsl BUG=449357 Committed: https://crrev.com/ce4c9f14d7e5efb61c2eab7d695f0f4b831543e7 Cr-Commit-Position: refs/heads/master@{#314766}

Patch Set 1 #

Patch Set 2 : Sync and fix BUILD.gn #

Patch Set 3 : Fix bad merge conflict #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -395 lines) Patch
M sandbox/linux/BUILD.gn View 1 3 chunks +3 lines, -3 lines 0 comments Download
M sandbox/linux/bpf_dsl/policy_compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
A + sandbox/linux/bpf_dsl/syscall_set.h View 3 chunks +3 lines, -5 lines 0 comments Download
A + sandbox/linux/bpf_dsl/syscall_set.cc View 1 chunk +1 line, -1 line 2 comments Download
A + sandbox/linux/bpf_dsl/syscall_set_unittest.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M sandbox/linux/sandbox_linux.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M sandbox/linux/sandbox_linux_test_sources.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf/sandbox_bpf.cc View 2 1 chunk +1 line, -1 line 0 comments Download
D sandbox/linux/seccomp-bpf/syscall_iterator.h View 1 chunk +0 lines, -105 lines 0 comments Download
D sandbox/linux/seccomp-bpf/syscall_iterator.cc View 1 chunk +0 lines, -144 lines 0 comments Download
D sandbox/linux/seccomp-bpf/syscall_iterator_unittest.cc View 1 chunk +0 lines, -124 lines 0 comments Download
M sandbox/linux/seccomp-bpf/verifier.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
mdempsky
5 years, 10 months ago (2015-02-05 04:03:25 UTC) #2
jln (very slow on Chromium)
lgtm if you want to deal with linux_seccomp.h later. https://codereview.chromium.org/896093002/diff/40001/sandbox/linux/bpf_dsl/syscall_set.cc File sandbox/linux/bpf_dsl/syscall_set.cc (right): https://codereview.chromium.org/896093002/diff/40001/sandbox/linux/bpf_dsl/syscall_set.cc#newcode9 sandbox/linux/bpf_dsl/syscall_set.cc:9: ...
5 years, 10 months ago (2015-02-05 05:59:07 UTC) #3
mdempsky
https://codereview.chromium.org/896093002/diff/40001/sandbox/linux/bpf_dsl/syscall_set.cc File sandbox/linux/bpf_dsl/syscall_set.cc (right): https://codereview.chromium.org/896093002/diff/40001/sandbox/linux/bpf_dsl/syscall_set.cc#newcode9 sandbox/linux/bpf_dsl/syscall_set.cc:9: #include "sandbox/linux/seccomp-bpf/linux_seccomp.h" On 2015/02/05 05:59:07, jln wrote: > This ...
5 years, 10 months ago (2015-02-05 06:00:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896093002/40001
5 years, 10 months ago (2015-02-05 06:01:28 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-05 06:23:38 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 06:26:21 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/ce4c9f14d7e5efb61c2eab7d695f0f4b831543e7
Cr-Commit-Position: refs/heads/master@{#314766}

Powered by Google App Engine
This is Rietveld 408576698