Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 896053002: Cleanup: Remove an unused parameter in StartupBrowserCreator. (Closed)

Created:
5 years, 10 months ago by Lei Zhang
Modified:
5 years, 10 months ago
Reviewers:
tommycli
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove an unused parameter in StartupBrowserCreator. Committed: https://crrev.com/8468daefc9eb29a3ecf895698798cabe047264f1 Cr-Commit-Position: refs/heads/master@{#314909}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -40 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 2 3 4 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/profiles/profile_window.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.h View 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator.cc View 1 2 3 4 7 chunks +7 lines, -12 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_browsertest.cc View 5 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/ui/startup/startup_browser_creator_interactive_uitest.cc View 1 2 3 3 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Lei Zhang
Somewhere around r111705, we stopped checking the result code we get back. Also, there's only ...
5 years, 10 months ago (2015-02-04 02:59:32 UTC) #2
Lei Zhang
ping
5 years, 10 months ago (2015-02-05 05:05:48 UTC) #3
tommycli
lgtm
5 years, 10 months ago (2015-02-05 17:32:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896053002/60001
5 years, 10 months ago (2015-02-05 17:40:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/31083)
5 years, 10 months ago (2015-02-05 17:43:12 UTC) #8
tommycli
still lgtm
5 years, 10 months ago (2015-02-05 21:31:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896053002/80001
5 years, 10 months ago (2015-02-05 21:55:03 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 10 months ago (2015-02-05 23:16:29 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 23:19:54 UTC) #14
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/8468daefc9eb29a3ecf895698798cabe047264f1
Cr-Commit-Position: refs/heads/master@{#314909}

Powered by Google App Engine
This is Rietveld 408576698