Source/modules/serviceworkers/ServiceWorkerGlobalScope.h - Issue 896043004: Tests for WaitUntilObserver and focus/openining windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerGlobalScope.h

Issue 896043004: Tests for WaitUntilObserver and focus/openining windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@sw_client_focus_cleanup

Patch Set: review comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/serviceworker/chromium/resources/notificationclick-can-openwindow.js ('k') | Source/modules/serviceworkers/WaitUntilObserver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/ServiceWorkerGlobalScope.h

diff --git a/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h b/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h

index 0793a0c1e5e50d84b59dd1db8a9e73a4952e3b55..a62b6bfedfce51d5ccae256df4bf829db38f821f 100644

--- a/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h

+++ b/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h

@@ -93,10 +93,6 @@ public:

DECLARE_VIRTUAL_TRACE();

- // Timeout before a service worker that was given window interaction

- // permission loses them. The unit is seconds.

- static const int kWindowInteractionTimeout = 10;

private:

class SkipWaitingCallback;