Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 896043003: test-parsing.cc: Test fix. (Closed)

Created:
5 years, 10 months ago by marja
Modified:
5 years, 10 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

test-parsing.cc: Test fix. The syntax of this test snippet was so wrong ("function function") that it wasn't testing what it was supposed to test. R=rossberg@chromium.org BUG= Committed: https://crrev.com/39010859f8f994842ca12195c8630d0a68fb993b Cr-Commit-Position: refs/heads/master@{#26433}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M test/cctest/test-parsing.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
marja
rossberg, ptal at this trivial fix
5 years, 10 months ago (2015-02-04 15:01:37 UTC) #1
rossberg
lgtm
5 years, 10 months ago (2015-02-04 15:48:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896043003/1
5 years, 10 months ago (2015-02-04 15:50:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 16:31:46 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 16:31:57 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/39010859f8f994842ca12195c8630d0a68fb993b
Cr-Commit-Position: refs/heads/master@{#26433}

Powered by Google App Engine
This is Rietveld 408576698