Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 896033004: chrome: Fixes for Linux ChromiumOS ozone build (Closed)

Created:
5 years, 10 months ago by spang
Modified:
5 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome: Fixes for Linux ChromiumOS ozone build This fixes the path to event_rewriter_unittest.cc as well as adds a missing dependency to chrome/browser/chromeos/BUILD.gn (already added to GYP, forgot GN). BUG=chromium:445627 TEST=gn gen out_gn_ozone --args='os="chromeos" use_ozone=true' (along with many other pending fixes) Committed: https://crrev.com/6071b4517db1a2859393f1d9140621195f716b40 Cr-Commit-Position: refs/heads/master@{#314479}

Patch Set 1 #

Total comments: 2

Patch Set 2 : drop conditional change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/chromeos/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
spang
5 years, 10 months ago (2015-02-04 01:02:35 UTC) #2
Nico
lgtm, thanks. one question below, fine to cq either way https://codereview.chromium.org/896033004/diff/1/chrome/test/BUILD.gn File chrome/test/BUILD.gn (right): https://codereview.chromium.org/896033004/diff/1/chrome/test/BUILD.gn#newcode1672 ...
5 years, 10 months ago (2015-02-04 01:23:08 UTC) #3
spang
https://codereview.chromium.org/896033004/diff/1/chrome/test/BUILD.gn File chrome/test/BUILD.gn (right): https://codereview.chromium.org/896033004/diff/1/chrome/test/BUILD.gn#newcode1672 chrome/test/BUILD.gn:1672: if (is_chromeos && use_ozone) { On 2015/02/04 01:23:08, Nico ...
5 years, 10 months ago (2015-02-04 01:48:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/896033004/20001
5 years, 10 months ago (2015-02-04 01:49:59 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-04 02:28:35 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 02:29:39 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6071b4517db1a2859393f1d9140621195f716b40
Cr-Commit-Position: refs/heads/master@{#314479}

Powered by Google App Engine
This is Rietveld 408576698