Use the local user's email when connecting to It2MeHelpeeChannel

Use the local user's email when connecting to It2MeHelpeeChannel

An It2Me connection requires an email for domain policy check.
We should use the email of the helpee instead of the helper.

Summary of changes:
1. Modifies it2meHelpeeChannel to fetch its token and the user's credentials
   using remoting.identity.
2. Implement the background page as an object to initialize remoting.identity
   appropriately.
3. Makes the consentDialog argument optional in remoting.identity as user
   consent is suggested as opposed to required in the chrome identity API.

BUG=454897
Committed: https://crrev.com/5e4c4c5a1cabe2e05cb0cd70b15b1afb507b9d8e
Cr-Commit-Position: refs/heads/master@{#314651}

[kelvinp, 2015-02-03 23:08:29]

kelvinp@chromium.org changed reviewers:
+ dcaiafa@chromium.org, jamiewalch@chromium.org

[kelvinp, 2015-02-03 23:08:37]

Patchset #2 (id:20001) has been deleted

[kelvinp, 2015-02-03 23:08:42]

Patchset #1 (id:1) has been deleted

[kelvinp, 2015-02-03 23:10:11]

Patchset #1 (id:40001) has been deleted

[kelvinp, 2015-02-03 23:11:09]

PTAL

https://codereview.chromium.org/896003002/diff/60001/remoting/webapp/crd/js/i...
File remoting/webapp/crd/js/it2me_helpee_channel.js (right):

https://codereview.chromium.org/896003002/diff/60001/remoting/webapp/crd/js/i...
remoting/webapp/crd/js/it2me_helpee_channel.js:264: /** @param {{email:string,
token:string}|Promise} result */
(| Promise) is there to make JSCompile happy as it incorrectly believes that all
functions in the then handler should be a promise.

https://codereview.chromium.org/896003002/diff/60001/remoting/webapp/crd/js/i...
remoting/webapp/crd/js/it2me_helpee_channel.js:391: * @param {string|Promise}
token
(| Promise) is there to make JSCompile happy as it incorrectly believes that all
functions in the then handler should be a promise.

[dcaiafa, 2015-02-04 00:12:35]

https://codereview.chromium.org/896003002/diff/60001/remoting/webapp/crd/js/b...
File remoting/webapp/crd/js/background.js (right):

https://codereview.chromium.org/896003002/diff/60001/remoting/webapp/crd/js/b...
remoting/webapp/crd/js/background.js:19: * @type {remoting.AppLauncher}
nit: do you guys know about the short form of this statement? As in:
/** @private {remoting.AppLauncher} */

I personally prefer it.

https://codereview.chromium.org/896003002/diff/60001/remoting/webapp/crd/js/b...
remoting/webapp/crd/js/background.js:68: this.activationHandler_ = new
base.Disposables();
Why can't this be just null? It's never disposed of.

https://codereview.chromium.org/896003002/diff/60001/remoting/webapp/crd/js/i...
File remoting/webapp/crd/js/identity.js (right):

https://codereview.chromium.org/896003002/diff/60001/remoting/webapp/crd/js/i...
remoting/webapp/crd/js/identity.js:24: * @param
{remoting.Identity.ConsentDialog=} consentDialog
nit: According to the Google style guide, optional javascript parameters should
start with the "opt_" prefix. I don't know how closely we follow the guide,
though.

https://codereview.chromium.org/896003002/diff/60001/remoting/webapp/crd/js/i...
File remoting/webapp/crd/js/it2me_helpee_channel.js (right):

https://codereview.chromium.org/896003002/diff/60001/remoting/webapp/crd/js/i...
remoting/webapp/crd/js/it2me_helpee_channel.js:266: return
that.connectToHost_(result.email, result.token);
I'm confused. connectToHost_ doesn't return anything. Do you expect it to return
a Promise?

[kelvinp, 2015-02-04 00:38:14]

PTAL

https://codereview.chromium.org/896003002/diff/60001/remoting/webapp/crd/js/b...
File remoting/webapp/crd/js/background.js (right):

https://codereview.chromium.org/896003002/diff/60001/remoting/webapp/crd/js/b...
remoting/webapp/crd/js/background.js:19: * @type {remoting.AppLauncher}
On 2015/02/04 00:12:35, dcaiafa wrote:
> nit: do you guys know about the short form of this statement? As in:
> /** @private {remoting.AppLauncher} */
> 
> I personally prefer it.

Glad to know.  I love it. Done.

https://codereview.chromium.org/896003002/diff/60001/remoting/webapp/crd/js/b...
remoting/webapp/crd/js/background.js:68: this.activationHandler_ = new
base.Disposables();
On 2015/02/04 00:12:35, dcaiafa wrote:
> Why can't this be just null? It's never disposed of.

It is artifacts from a previous experiment.  Removed.

https://codereview.chromium.org/896003002/diff/60001/remoting/webapp/crd/js/i...
File remoting/webapp/crd/js/identity.js (right):

https://codereview.chromium.org/896003002/diff/60001/remoting/webapp/crd/js/i...
remoting/webapp/crd/js/identity.js:24: * @param
{remoting.Identity.ConsentDialog=} consentDialog
On 2015/02/04 00:12:35, dcaiafa wrote:
> nit: According to the Google style guide, optional javascript parameters
should
> start with the "opt_" prefix. I don't know how closely we follow the guide,
> though.

Done.

https://codereview.chromium.org/896003002/diff/60001/remoting/webapp/crd/js/i...
File remoting/webapp/crd/js/it2me_helpee_channel.js (right):

https://codereview.chromium.org/896003002/diff/60001/remoting/webapp/crd/js/i...
remoting/webapp/crd/js/it2me_helpee_channel.js:266: return
that.connectToHost_(result.email, result.token);
On 2015/02/04 00:12:35, dcaiafa wrote:
> I'm confused. connectToHost_ doesn't return anything. Do you expect it to
return
> a Promise?

Done.

[dcaiafa, 2015-02-04 01:00:33]

I'm not super familiar with this code, and I had to take a refresh-course on
Promises (I always have to) to follow it, but AFAIAC LGTM :)

[kelvinp, 2015-02-04 01:04:13]

The CQ bit was checked by kelvinp@chromium.org

[commit-bot: I haz the power, 2015-02-04 01:04:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/896003002/80001

[commit-bot: I haz the power, 2015-02-04 01:59:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-04 01:59:21]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kelvinp, 2015-02-04 18:48:49]

New patchsets have been uploaded after l-g-t-m from dcaiafa@chromium.org

[kelvinp, 2015-02-04 18:49:02]

The CQ bit was checked by kelvinp@chromium.org

[commit-bot: I haz the power, 2015-02-04 18:49:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/896003002/100001

[commit-bot: I haz the power, 2015-02-04 19:32:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-04 19:32:06]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[kelvinp, 2015-02-04 21:26:12]

The CQ bit was checked by kelvinp@chromium.org

[commit-bot: I haz the power, 2015-02-04 21:27:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/896003002/100001

[commit-bot: I haz the power, 2015-02-04 22:08:06]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2015-02-04 22:09:06]

Patchset 3 (id:??) landed as
https://crrev.com/5e4c4c5a1cabe2e05cb0cd70b15b1afb507b9d8e
Cr-Commit-Position: refs/heads/master@{#314651}