Source/core/rendering/RenderInline.cpp - Issue 895953003: Insert an anonymous inline-table when inserting a table part under an inline.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderInline.cpp

Issue 895953003: Insert an anonymous inline-table when inserting a table part under an inline. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Code review - lump similar tests together in one file. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderInline.cpp

diff --git a/Source/core/rendering/RenderInline.cpp b/Source/core/rendering/RenderInline.cpp

index 4cfbffd965010dd8b14c3651a55b8f98fe8f7714..7cb367f4ea0ff9944b8c13a34308cd8857ef3805 100644

--- a/Source/core/rendering/RenderInline.cpp

+++ b/Source/core/rendering/RenderInline.cpp

@@ -326,7 +326,7 @@ void RenderInline::addChildIgnoringContinuation(LayoutObject* newChild, LayoutOb

if (!beforeChild && isAfterContent(lastChild()))

beforeChild = lastChild();

- if (!newChild->isInline() && !newChild->isFloatingOrOutOfFlowPositioned()) {

+ if (!newChild->isInline() && !newChild->isFloatingOrOutOfFlowPositioned() && !newChild->isTablePart()) {

// We are placing a block inside an inline. We have to perform a split of this

// inline into continuations. This involves creating an anonymous block box to hold

// |newChild|. We then make that block box a continuation of this inline. We take all of

« no previous file with comments | « Source/core/layout/LayoutTable.cpp ('k') | no next file » | no next file with comments »