content/browser/fileapi/chrome_blob_storage_context.cc - Issue 895933007: [Storage] Blob items are now shared between blobs. Ready for disk swap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/fileapi/chrome_blob_storage_context.cc

Issue 895933007: [Storage] Blob items are now shared between blobs. Ready for disk swap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup and added one more histogram Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/fileapi/blob_url_request_job_unittest.cc ('k') | content/browser/indexed_db/indexed_db_dispatcher_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/fileapi/chrome_blob_storage_context.cc

diff --git a/content/browser/fileapi/chrome_blob_storage_context.cc b/content/browser/fileapi/chrome_blob_storage_context.cc

index 5fc26e40f3e08eec82ce3169e4c8be022a36ba92..f8753b5ea77e521d8f0c4fc24d517ee965bfdd6c 100644

--- a/content/browser/fileapi/chrome_blob_storage_context.cc

+++ b/content/browser/fileapi/chrome_blob_storage_context.cc

@@ -69,12 +69,11 @@ scoped_ptr<BlobHandle> ChromeBlobStorageContext::CreateMemoryBackedBlob(

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

std::string uuid(base::GenerateGUID());

- scoped_ptr<storage::BlobDataBuilder> blob_data_builder(

- new storage::BlobDataBuilder(uuid));

- blob_data_builder->AppendData(data, length);

+ storage::BlobDataBuilder blob_data_builder(uuid);

+ blob_data_builder.AppendData(data, length);

scoped_ptr<storage::BlobDataHandle> blob_data_handle =

- context_->AddFinishedBlob(*blob_data_builder.get());

+ context_->AddFinishedBlob(&blob_data_builder);

if (!blob_data_handle)

return scoped_ptr<BlobHandle>();