content/browser/loader/upload_data_stream_builder_unittest.cc - Issue 895933007: [Storage] Blob items are now shared between blobs. Ready for disk swap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/upload_data_stream_builder_unittest.cc

Issue 895933007: [Storage] Blob items are now shared between blobs. Ready for disk swap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/indexed_db/indexed_db_dispatcher_host.cc ('k') | content/browser/service_worker/service_worker_cache.cc » ('j') | storage/browser/blob/blob_data_builder.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/upload_data_stream_builder_unittest.cc

diff --git a/content/browser/loader/upload_data_stream_builder_unittest.cc b/content/browser/loader/upload_data_stream_builder_unittest.cc

index 4f8e8d40883e8d51c7ee2461ebf8bc150ec41cd8..a40082d9a20b4d0411a9fb213fd26c4ca90ee5ae 100644

--- a/content/browser/loader/upload_data_stream_builder_unittest.cc

+++ b/content/browser/loader/upload_data_stream_builder_unittest.cc

@@ -109,15 +109,16 @@ TEST(UploadDataStreamBuilderTest, ResolveBlobAndCreateUploadDataStream) {

scoped_ptr<BlobDataBuilder> blob_data_builder(

new BlobDataBuilder(blob_id0));

scoped_ptr<BlobDataHandle> handle1 =

- blob_storage_context.AddFinishedBlob(*blob_data_builder.get());

+ blob_storage_context.AddFinishedBlob(blob_data_builder.get());

const std::string blob_id1("id-1");

- blob_data_builder.reset(new BlobDataBuilder(blob_id1));

- blob_data_builder->AppendData("BlobData");

- blob_data_builder->AppendFile(

- base::FilePath(FILE_PATH_LITERAL("BlobFile.txt")), 0, 20, time1);

+ blob_data_builder.reset(

+ BlobDataBuilder::Create(blob_id1)

+ ->AppendData("BlobData")

+ ->AppendFile(base::FilePath(FILE_PATH_LITERAL("BlobFile.txt")), 0,

+ 20, time1));

scoped_ptr<BlobDataHandle> handle2 =

- blob_storage_context.AddFinishedBlob(*blob_data_builder.get());

+ blob_storage_context.AddFinishedBlob(blob_data_builder.get());

// Setup upload data elements for comparison.

auto blob_data = blob_data_builder->BuildSnapshot();