Chromium Code Reviews Chromium Code Reviews
Issue 895933007:
[Storage] Blob items are now shared between blobs. Ready for disk swap. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index b736f7de677dd451846ee0a2d042034a871a62f9..b208c9cdb542c41ef5584765b06563d2814001b0 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -36911,6 +36911,13 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </summary> |
| </histogram> |
| +<histogram name="Storage.Blob.ReusedItem" units="Boolean"> |
|
Alexei Svitkine (slow)
2015/02/10 16:05:06
Please use enum="BooleanReused" (add a BooleanReus
dmurph
2015/02/10 22:17:47
Done.
|
| + <owner>dmurph@chromium.org</owner> |
| + <summary> |
| + True if we reuse an item for a blob created from using Blob.slice. |
|
Alexei Svitkine (slow)
2015/02/10 16:05:06
Mention when this is logged, do so for all of thes
dmurph
2015/02/10 22:17:47
Done.
|
| + </summary> |
| +</histogram> |
| + |
| <histogram name="Storage.Blob.StorageSizeAfterAppend" units="KB"> |
| <owner>dmurph@chromium.org</owner> |
| <summary> |
| @@ -36929,6 +36936,11 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </summary> |
| </histogram> |
| +<histogram name="Storage.Blob.TotalSize" units="KB"> |
| + <owner>dmurph@chromium.org</owner> |
| + <summary>The total in-memory size in KB of finished blobs.</summary> |
| +</histogram> |
| + |
| <histogram name="Storage.BlobItemSize" units="KB"> |
| <owner>dmurph@chromium.org</owner> |
| <summary> |
| @@ -36936,6 +36948,32 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </summary> |
| </histogram> |
| +<histogram name="Storage.BlobItemSize.BlobSlice" units="KB"> |
| + <owner>dmurph@chromium.org</owner> |
| + <summary> |
| + The size in KB of items (or parts of items) appended to blobs that come from |
| + the slicing of other blobs. This happens when using Blob.slice, where we |
| + are using a part of an item in the original blob (not the whole item). |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="Storage.BlobItemSize.File.Unknown" units="Boolean"> |
|
Alexei Svitkine (slow)
2015/02/10 16:05:06
enum="BooleanUnknown", add it if it doesn't exist.
dmurph
2015/02/10 22:17:47
Done.
|
| + <owner>dmurph@chromium.org</owner> |
| + <summary> |
| + True if the file size on blob append is unknown (which means the full file), |
| + or false if a specific file length was populated. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="Storage.BlobItemSize.FileSystem.Unknown" units="Boolean"> |
| + <owner>dmurph@chromium.org</owner> |
| + <summary> |
| + True if the file size of a filesystem object on blob append is unknown |
| + (which means the full file), or false if a specific file length was |
| + populated. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="Suggestions.FailedRequestErrorCode" enum="NetErrorCodes"> |
| <owner>mathp@chromium.org</owner> |
| <summary> |
| @@ -63476,10 +63514,12 @@ To add a new entry, add it with any value and run test to compute valid value. |
| <histogram_suffixes name="Storage.BlobAppendableItems" separator="."> |
| <suffix name="Bytes" label="Appending bytes."/> |
| - <suffix name="File" label="Appending a file."/> |
| - <suffix name="FileSystem" label="Appending a filesystem object."/> |
| + <suffix name="File" label="Appending a file with a known size."/> |
| + <suffix name="FileSystem" |
| + label="Appending a filesystem object with known size."/> |
| <suffix name="Blob" label="Appending a blob."/> |
| <affected-histogram name="Storage.BlobItemSize"/> |
| + <affected-histogram name="Storage.BlobItemSize.BlobSlice"/> |
| </histogram_suffixes> |
| <histogram_suffixes name="SyzygyStartupTime"> |
