Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 895933003: Fix segv in CPDF_DataAvail::CheckRoot() when /Root object is a string. (Closed)

Created:
5 years, 10 months ago by Tom Sepez
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang, jun_fang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix segv in CPDF_DataAvail::CheckRoot() when /Root object is a string. Handles the case of this malformed PDF without crashing. Note that to get a reproducible test case, a small fix is applied to our .py script which results in some whitespace/numbering difs across the resources (down the road, we ought to generate them on the fly in an intermediate directory). BUG=454695 R=jun_fang@foxitsoftware.com, thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/219b3dab7e184bf8742f61527e37053b04903ff0

Patch Set 1 #

Patch Set 2 : Typo in comment in .py file #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -87 lines) Patch
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M fpdfsdk/src/fpdfview_embeddertest.cpp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M testing/resources/bug_451265.pdf View 1 chunk +15 lines, -15 lines 0 comments Download
M testing/resources/bug_452455.pdf View 1 chunk +18 lines, -18 lines 0 comments Download
A testing/resources/bug_454695.in View 1 chunk +12 lines, -0 lines 0 comments Download
A testing/resources/bug_454695.pdf View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
M testing/resources/bug_57.pdf View 1 chunk +6 lines, -6 lines 0 comments Download
M testing/resources/hello_world.pdf View 1 chunk +7 lines, -7 lines 0 comments Download
M testing/resources/named_dests.pdf View 1 chunk +23 lines, -23 lines 0 comments Download
M testing/resources/trailer_as_hexstring.pdf View 1 chunk +5 lines, -4 lines 0 comments Download
M testing/resources/trailer_unterminated.pdf View 1 chunk +4 lines, -4 lines 0 comments Download
M testing/resources/weblinks.pdf View 1 chunk +7 lines, -7 lines 0 comments Download
M testing/tools/fixup_pdf_template.py View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Tom Sepez
Lei, Jun, please review.
5 years, 10 months ago (2015-02-03 20:35:45 UTC) #2
jun_fang
On 2015/02/03 20:35:45, Tom Sepez wrote: > Lei, Jun, please review. LGTM
5 years, 10 months ago (2015-02-03 23:20:20 UTC) #3
Tom Sepez
Lei, you want to take a quick look before I land this? Thanks.
5 years, 10 months ago (2015-02-05 18:31:21 UTC) #4
Lei Zhang
You probably need to resolve merge conflicts, but lgtm.
5 years, 10 months ago (2015-02-05 18:35:28 UTC) #5
Tom Sepez
5 years, 10 months ago (2015-02-05 18:41:12 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
219b3dab7e184bf8742f61527e37053b04903ff0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698