Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Unified Diff: ui/touch_selection/touch_selection_controller.h

Issue 895903003: Adding UMA logging to touch text selection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Min duration: 1ms -> 1000ms Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/touch_selection/touch_selection_controller.h
diff --git a/ui/touch_selection/touch_selection_controller.h b/ui/touch_selection/touch_selection_controller.h
index 2bcefbd20542c1a12477ccb93ed6eec25fc7a8ea..f4d1ad0eaef0e640eb83173ed4f63f46a41062a2 100644
--- a/ui/touch_selection/touch_selection_controller.h
+++ b/ui/touch_selection/touch_selection_controller.h
@@ -115,6 +115,8 @@ class UI_TOUCH_SELECTION_EXPORT TouchSelectionController
bool GetEndVisible() const;
TouchHandle::AnimationStyle GetAnimationStyle(bool was_active) const;
+ void LogSelectionEnd();
+
TouchSelectionControllerClient* const client_;
const base::TimeDelta tap_timeout_;
const float tap_slop_;
@@ -140,6 +142,11 @@ class UI_TOUCH_SELECTION_EXPORT TouchSelectionController
bool temporarily_hidden_;
+ base::TimeTicks selection_start_time_;
+ // Whether a selection handle was dragged during the current 'selection
+ // session' - i.e. since the current selection has been activated.
+ bool selection_handle_dragged_;
+
DISALLOW_COPY_AND_ASSIGN(TouchSelectionController);
};

Powered by Google App Engine
This is Rietveld 408576698