Files.app: Add ExternalMetadataProvider class.

Files.app: Add ExternalMetadataProvider class.

It provides metadata from fileManagerPrivate.getEntriesProperty.

BUG=453242
TEST=FileManagerJsTest.ExternalMetadataProvider

Committed: https://crrev.com/148b6553115ae85d87d7c82b8fe3725cba21b3c1
Cr-Commit-Position: refs/heads/master@{#314508}

[hirono, 2015-02-03 09:40:01]

hirono@chromium.org changed reviewers:
+ yawano@chromium.org

[hirono, 2015-02-03 09:40:01]

PTAL, thanks!

[yawano, 2015-02-03 10:48:00]

https://codereview.chromium.org/895873002/diff/20001/ui/file_manager/file_man...
File
ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js
(right):

https://codereview.chromium.org/895873002/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js:6:
* @typedef {{
nit: Missing shared and imageRotation.

https://codereview.chromium.org/895873002/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js:20:
*   contentMimeType: (string|undefined),
very small nit: contentMimeType, customIconUrl, size, and modificationTime
doesn't seem to become undefined.

https://codereview.chromium.org/895873002/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js:58:
this.scheduled_ = false;
This variable seems not to be used in this CL.

[hirono, 2015-02-04 04:29:28]

https://codereview.chromium.org/895873002/diff/20001/ui/file_manager/file_man...
File
ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js
(right):

https://codereview.chromium.org/895873002/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js:6:
* @typedef {{
On 2015/02/03 10:48:00, yawano wrote:
> nit: Missing shared and imageRotation.

Done.

https://codereview.chromium.org/895873002/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js:20:
*   contentMimeType: (string|undefined),
On 2015/02/03 10:48:00, yawano wrote:
> very small nit: contentMimeType, customIconUrl, size, and modificationTime
> doesn't seem to become undefined.

Done.

https://codereview.chromium.org/895873002/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/metadata/external_metadata_provider.js:58:
this.scheduled_ = false;
On 2015/02/03 10:48:00, yawano wrote:
> This variable seems not to be used in this CL.

Yes this was mixed in.

[yawano, 2015-02-04 04:31:54]

lgtm.

[hirono, 2015-02-04 04:34:46]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2015-02-04 04:35:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/895873002/60001

[hirono, 2015-02-04 05:21:29]

New patchsets have been uploaded after l-g-t-m from yawano@chromium.org

[hirono, 2015-02-04 05:23:02]

@yawano - The previous test does not pass if the test run in other than TOK time
zone. Please take another look? Thanks!

[yawano, 2015-02-04 05:40:44]

Still lgtm.

[hirono, 2015-02-04 05:44:06]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2015-02-04 05:44:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/895873002/80001

[commit-bot: I haz the power, 2015-02-04 05:52:27]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-02-04 05:53:44]

Patchset 5 (id:??) landed as
https://crrev.com/148b6553115ae85d87d7c82b8fe3725cba21b3c1
Cr-Commit-Position: refs/heads/master@{#314508}