Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Issue 895863002: Fixes tray_session_length_limit_unittest timeout on valgrind. (Closed)

Created:
5 years, 10 months ago by Jun Mukai
Modified:
5 years, 10 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, sadrul, stevenjb+watch_chromium.org, oshima+watch_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes tray_session_length_limit_unittest timeout on valgrind. According to test runs on my machine, the test looks like suspended after the test body finished, which seems to be waiting for remaining timer tests. ClearSessionLengthLimit() should be called at the end. This also has cosmetic changes like NULL -> nullptr BUG=454601 R=stevenjb@chromium.org TEST=build with build_for_tool=memcheck, run ash_unittests with valgrind, and confirmed the test finishes in realistic time Committed: https://crrev.com/75be556f6fc83ffdac88fd6ec12f846018aa8d2b Cr-Commit-Position: refs/heads/master@{#314386}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M ash/system/chromeos/session/tray_session_length_limit_unittest.cc View 4 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jun Mukai
5 years, 10 months ago (2015-02-03 06:11:23 UTC) #1
stevenjb
lgtm
5 years, 10 months ago (2015-02-03 19:02:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895863002/1
5 years, 10 months ago (2015-02-03 19:05:57 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 19:42:55 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 19:44:21 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/75be556f6fc83ffdac88fd6ec12f846018aa8d2b
Cr-Commit-Position: refs/heads/master@{#314386}

Powered by Google App Engine
This is Rietveld 408576698