content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java - Issue 895843002: Content: Add convenience method for animations over SurfaceViews.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java

Issue 895843002: Content: Add convenience method for animations over SurfaceViews. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/android/java/src/org/chromium/content_shell/ShellManager.java ('k') | ui/android/java/src/org/chromium/ui/base/WindowAndroid.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java

diff --git a/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java b/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java

index ee048bacb069889d17067471ccc3ea49db8604c9..2d94b121e4a73901d8f9983a6778d016a19eae83 100644

--- a/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java

+++ b/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java

@@ -73,6 +73,10 @@ public class ContentShellActivity extends Activity {

mWindowAndroid = new ActivityWindowAndroid(this);

mWindowAndroid.restoreInstanceState(savedInstanceState);

mShellManager.setWindow(mWindowAndroid);

+ // Set up the animation placeholder to be the SurfaceView. This disables the

+ // SurfaceView's 'hole' clipping during animations that are notified to the window.

+ mWindowAndroid.setAnimationPlaceholderView(

+ mShellManager.getContentViewRenderView().getSurfaceView());

String startupUrl = getUrlFromIntent(getIntent());

if (!TextUtils.isEmpty(startupUrl)) {