Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: chrome/browser/ui/views/frame/opaque_browser_frame_view.cc

Issue 895803003: [Profiles] Remove the NotificationService from the ProfileInfoCache (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
diff --git a/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc b/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
index 775ca5a83cd7d7aa060a8dd99b3b052fad07e526..1c3a9382d205f18ff15d159fb5d199243e4f3f15 100644
--- a/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
+++ b/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
@@ -10,7 +10,6 @@
#include "base/compiler_specific.h"
#include "base/prefs/pref_service.h"
#include "base/strings/utf_string_conversions.h"
-#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/profiles/profiles_state.h"
#include "chrome/browser/signin/signin_header_helper.h"
#include "chrome/browser/themes/theme_properties.h"
@@ -147,15 +146,7 @@ OpaqueBrowserFrameView::OpaqueBrowserFrameView(BrowserFrame* frame,
window_title_->set_id(VIEW_ID_WINDOW_TITLE);
AddChildView(window_title_);
- if (browser_view->IsRegularOrGuestSession() && switches::IsNewAvatarMenu())
- UpdateNewStyleAvatarInfo(this, NewAvatarButton::THEMED_BUTTON);
- else
- UpdateAvatarInfo();
-
- if (!browser_view->IsOffTheRecord()) {
- registrar_.Add(this, chrome::NOTIFICATION_PROFILE_CACHED_INFO_CHANGED,
- content::NotificationService::AllSources());
- }
+ UpdateAvatar();
platform_observer_.reset(OpaqueBrowserFrameViewPlatformSpecific::Create(
this, layout_, browser_view->browser()->profile()));
@@ -374,28 +365,6 @@ gfx::ImageSkia OpaqueBrowserFrameView::GetFaviconForTabIconView() {
}
///////////////////////////////////////////////////////////////////////////////
-// OpaqueBrowserFrameView, protected:
-
-void OpaqueBrowserFrameView::Observe(
- int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) {
- switch (type) {
- case chrome::NOTIFICATION_PROFILE_CACHED_INFO_CHANGED:
- if (browser_view() ->IsRegularOrGuestSession() &&
- switches::IsNewAvatarMenu()) {
- UpdateNewStyleAvatarInfo(this, NewAvatarButton::THEMED_BUTTON);
- } else {
- UpdateAvatarInfo();
- }
- break;
- default:
- NOTREACHED() << "Got a notification we didn't register for!";
- break;
- }
-}
-
-///////////////////////////////////////////////////////////////////////////////
// OpaqueBrowserFrameView, OpaqueBrowserFrameViewLayoutDelegate implementation:
bool OpaqueBrowserFrameView::ShouldShowWindowIcon() const {
@@ -478,8 +447,9 @@ gfx::Size OpaqueBrowserFrameView::GetTabstripPreferredSize() const {
}
///////////////////////////////////////////////////////////////////////////////
-// OpaqueBrowserFrameView, views::View overrides:
+// OpaqueBrowserFrameView, protected:
+// views::View:
void OpaqueBrowserFrameView::OnPaint(gfx::Canvas* canvas) {
if (frame()->IsFullscreen())
return; // Nothing is visible, so don't bother to paint.
@@ -503,6 +473,11 @@ void OpaqueBrowserFrameView::OnPaint(gfx::Canvas* canvas) {
PaintRestoredClientEdge(canvas);
}
+// BrowserNonClientFrameView:
+void OpaqueBrowserFrameView::UpdateNewStyleAvatar() {
+ UpdateNewStyleAvatarInfo(this, NewAvatarButton::THEMED_BUTTON);
+}
+
///////////////////////////////////////////////////////////////////////////////
// OpaqueBrowserFrameView, private:
« no previous file with comments | « chrome/browser/ui/views/frame/opaque_browser_frame_view.h ('k') | chrome/browser/ui/webui/ntp/ntp_login_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698