Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: chrome/browser/ui/webui/options/options_ui_browsertest.cc

Issue 895803003: [Profiles] Remove the NotificationService from the ProfileInfoCache (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: s/public/protected/ Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/options/manage_profile_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/options/options_ui_browsertest.cc
diff --git a/chrome/browser/ui/webui/options/options_ui_browsertest.cc b/chrome/browser/ui/webui/options/options_ui_browsertest.cc
index 4a26fc2137967d789382a2e2097c5d3477ff828f..7de5e6d955525719cab1f83929fe1428eae055f7 100644
--- a/chrome/browser/ui/webui/options/options_ui_browsertest.cc
+++ b/chrome/browser/ui/webui/options/options_ui_browsertest.cc
@@ -230,10 +230,6 @@ IN_PROC_BROWSER_TEST_F(OptionsUIBrowserTest, MAYBE_VerifyManagedSignout) {
EXPECT_TRUE(profile_info_cache.GetIndexOfProfileWithPath(profile_dir) !=
std::string::npos);
- content::WindowedNotificationObserver wait_for_profile_deletion(
- chrome::NOTIFICATION_PROFILE_CACHED_INFO_CHANGED,
- content::NotificationService::AllSources());
-
// TODO(kaliamoorthi): Get the macos problem fixed and remove this code.
// Deleting the Profile also destroys all browser windows of that Profile.
// Wait for the current browser to close before resuming, otherwise
@@ -246,8 +242,6 @@ IN_PROC_BROWSER_TEST_F(OptionsUIBrowserTest, MAYBE_VerifyManagedSignout) {
browser()->tab_strip_model()->GetActiveWebContents(),
"$('disconnect-managed-profile-ok').click();"));
- wait_for_profile_deletion.Wait();
Dan Beam 2015/02/25 18:02:58 why is this not necessary now?
noms (inactive) 2015/02/25 19:29:53 If this is doing what it says it's doing (waiting
-
EXPECT_TRUE(profile_info_cache.GetIndexOfProfileWithPath(profile_dir) ==
std::string::npos);
« no previous file with comments | « chrome/browser/ui/webui/options/manage_profile_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698