Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5054)

Unified Diff: chrome/browser/ui/views/frame/glass_browser_frame_view.cc

Issue 895803003: [Profiles] Remove the NotificationService from the ProfileInfoCache (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: clean up views code Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/glass_browser_frame_view.cc
diff --git a/chrome/browser/ui/views/frame/glass_browser_frame_view.cc b/chrome/browser/ui/views/frame/glass_browser_frame_view.cc
index 4eaaf0647767725b64d2b1ea8db8a70f7f093b33..4c90576f0e11692ce860309c43ff48da0d253370 100644
--- a/chrome/browser/ui/views/frame/glass_browser_frame_view.cc
+++ b/chrome/browser/ui/views/frame/glass_browser_frame_view.cc
@@ -8,7 +8,6 @@
#include "base/strings/utf_string_conversions.h"
#include "chrome/app/chrome_command_ids.h"
#include "chrome/app/chrome_dll_resource.h"
-#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/signin/signin_header_helper.h"
#include "chrome/browser/themes/theme_properties.h"
@@ -19,7 +18,6 @@
#include "chrome/browser/ui/views/tabs/tab_strip.h"
#include "chrome/browser/ui/views/toolbar/toolbar_view.h"
#include "components/signin/core/common/profile_management_switches.h"
-#include "content/public/browser/notification_service.h"
#include "grit/theme_resources.h"
#include "skia/ext/image_operations.h"
#include "ui/base/resource/resource_bundle_win.h"
@@ -97,15 +95,7 @@ GlassBrowserFrameView::GlassBrowserFrameView(BrowserFrame* frame,
if (browser_view->ShouldShowWindowIcon())
InitThrobberIcons();
- if (browser_view->IsRegularOrGuestSession() && switches::IsNewAvatarMenu())
- UpdateNewStyleAvatarInfo(this, NewAvatarButton::NATIVE_BUTTON);
- else
- UpdateAvatarInfo();
-
- if (!browser_view->IsOffTheRecord()) {
- registrar_.Add(this, chrome::NOTIFICATION_PROFILE_CACHED_INFO_CHANGED,
- content::NotificationService::AllSources());
- }
+ UpdateAvatar();
}
GlassBrowserFrameView::~GlassBrowserFrameView() {
@@ -202,6 +192,10 @@ gfx::Size GlassBrowserFrameView::GetMinimumSize() const {
return min_size;
}
+void GlassBrowserFrameView::UpdateNewStyleAvatar() {
+ UpdateNewStyleAvatarInfo(this, NewAvatarButton::NATIVE_BUTTON);
+}
+
///////////////////////////////////////////////////////////////////////////////
// GlassBrowserFrameView, views::NonClientFrameView implementation:
@@ -594,25 +588,6 @@ void GlassBrowserFrameView::DisplayNextThrobberFrame() {
reinterpret_cast<LPARAM>(throbber_icons_[throbber_frame_]));
}
-void GlassBrowserFrameView::Observe(
- int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) {
- switch (type) {
- case chrome::NOTIFICATION_PROFILE_CACHED_INFO_CHANGED:
- if (browser_view()->IsRegularOrGuestSession() &&
- switches::IsNewAvatarMenu()) {
- UpdateNewStyleAvatarInfo(this, NewAvatarButton::NATIVE_BUTTON);
- } else {
- UpdateAvatarInfo();
- }
- break;
- default:
- NOTREACHED() << "Got a notification we didn't register for!";
- break;
- }
-}
-
// static
void GlassBrowserFrameView::InitThrobberIcons() {
static bool initialized = false;

Powered by Google App Engine
This is Rietveld 408576698