Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Unified Diff: chrome/browser/profiles/profile_list_desktop_unittest.cc

Issue 895803003: [Profiles] Remove the NotificationService from the ProfileInfoCache (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cait nit Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_list_desktop_unittest.cc
diff --git a/chrome/browser/profiles/profile_list_desktop_unittest.cc b/chrome/browser/profiles/profile_list_desktop_unittest.cc
index 95f03c4dfc3e29088b28f6266b47206a568429aa..51905c88a2d92d1dab3ff124d98680db71cb498f 100644
--- a/chrome/browser/profiles/profile_list_desktop_unittest.cc
+++ b/chrome/browser/profiles/profile_list_desktop_unittest.cc
@@ -226,7 +226,7 @@ TEST_F(ProfileListDesktopTest, ModifyingNameResortsCorrectly) {
manager()->profile_info_cache()->SetNameOfProfileAtIndex(0,
ASCIIToUTF16(newname1));
const AvatarMenu::Item& item1next = model->GetItemAt(0);
- EXPECT_GT(change_count(), 1);
+ EXPECT_EQ(1, change_count());
EXPECT_EQ(0U, item1next.menu_index);
EXPECT_EQ(ASCIIToUTF16(name2), item1next.name);
@@ -245,14 +245,12 @@ TEST_F(ProfileListDesktopTest, ChangeOnNotify) {
manager()->CreateTestingProfile("Test 3");
- // Four changes happened via the call to CreateTestingProfile: adding the
- // profile to the cache, setting the user name, rebuilding the list of
- // profiles after the name change, and changing the avatar.
+ // Three changes happened via the call to CreateTestingProfile: adding the
+ // profile to the cache, setting the user name (which rebuilds the list of
+ // profiles after the name change) and changing the avatar.
// On Windows, an extra change happens to set the shortcut name for the
// profile.
- // TODO(michaelpg): Determine why five changes happen on ChromeOS and
- // investigate other platforms.
- EXPECT_GE(change_count(), 4);
+ EXPECT_GE(3, change_count());
ASSERT_EQ(3U, model->GetNumberOfItems());
const AvatarMenu::Item& item1 = model->GetItemAt(0);

Powered by Google App Engine
This is Rietveld 408576698