Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 895783005: [Android] Add option to wait for wifi after Reboot (Closed)

Created:
5 years, 10 months ago by perezju
Modified:
5 years, 10 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add option to wait for wifi after Reboot The value of the option is simply passed down to WaitUntilFullyBooted when block=True. BUG= Committed: https://crrev.com/2553633078ff7772245e6c9bc564173f7a701c0d Cr-Commit-Position: refs/heads/master@{#314345}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M build/android/pylib/device/device_utils.py View 1 2 chunks +4 lines, -2 lines 0 comments Download
M build/android/pylib/device/device_utils_test.py View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
perezju
5 years, 10 months ago (2015-02-03 14:51:30 UTC) #1
perezju
5 years, 10 months ago (2015-02-03 14:51:56 UTC) #3
jbudorick
lgtm w/ nits https://codereview.chromium.org/895783005/diff/1/build/android/pylib/device/device_utils.py File build/android/pylib/device/device_utils.py (right): https://codereview.chromium.org/895783005/diff/1/build/android/pylib/device/device_utils.py#newcode358 build/android/pylib/device/device_utils.py:358: wifi: A boolean indicaring if we ...
5 years, 10 months ago (2015-02-03 14:53:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895783005/20001
5 years, 10 months ago (2015-02-03 15:20:41 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-03 16:16:30 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 16:17:40 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2553633078ff7772245e6c9bc564173f7a701c0d
Cr-Commit-Position: refs/heads/master@{#314345}

Powered by Google App Engine
This is Rietveld 408576698