Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 895783004: Devtools Animations: Timeline interactions change the underlying style (Closed)

Created:
5 years, 10 months ago by samli
Modified:
5 years, 10 months ago
Reviewers:
dgozman, pfeldman
CC:
blink-reviews, shans, apavlov+blink_chromium.org, rjwright, Steve Block, caseq+blink_chromium.org, aandrey+blink_chromium.org, pfeldman+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, dstockwell, Timothy Loh, devtools-reviews_chromium.org, Eric Willigers, loislo+blink_chromium.org, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, darktears, blink-reviews-animation_chromium.org, vsevik+blink_chromium.org, Mike Lawther (Google), sergeyv+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools Animations: Timeline interactions change the underlying style As the user interacts with the animation timeline, timing information needs to be set on the affected node. This change reveals the selected animation and sets the inline style to the updated value. BUG=447083 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190011

Patch Set 1 #

Patch Set 2 : Fix annotations #

Total comments: 1

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -7 lines) Patch
M Source/devtools/front_end/elements/AnimationTimeline.js View 1 9 chunks +76 lines, -6 lines 0 comments Download
M Source/devtools/front_end/elements/AnimationsSidebarPane.js View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
samli
5 years, 10 months ago (2015-02-03 01:01:23 UTC) #2
samli
Can someone PTAL? Its been a week.
5 years, 10 months ago (2015-02-10 22:07:29 UTC) #4
pfeldman
lgtm https://codereview.chromium.org/895783004/diff/20001/Source/devtools/front_end/elements/AnimationTimeline.js File Source/devtools/front_end/elements/AnimationTimeline.js (right): https://codereview.chromium.org/895783004/diff/20001/Source/devtools/front_end/elements/AnimationTimeline.js#newcode460 Source/devtools/front_end/elements/AnimationTimeline.js:460: this._node.setAttributeValue("style", style + " " + valueString + ...
5 years, 10 months ago (2015-02-11 10:46:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895783004/20001
5 years, 10 months ago (2015-02-11 10:49:22 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/34768) mac_blink_rel on tryserver.blink (JOB_FAILED, ...
5 years, 10 months ago (2015-02-11 10:52:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895783004/40001
5 years, 10 months ago (2015-02-11 23:01:06 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 00:22:25 UTC) #13
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190011

Powered by Google App Engine
This is Rietveld 408576698