Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 895783002: Remove the Copresence Endpoints API. (Closed)

Created:
5 years, 10 months ago by rkc
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the Copresence Endpoints API. Since there are no plans to use this API at least for 1H 2015, there is no point leaving this code in Chrome. Removing this API to reduce code bloat. We can revisit adding this API again when this work gets prioritized. R=isherman@chromium.org, kalman@chromium.org, xiyuan@chromium.org BUG=452562 This flag is specified since we're deleting an enum from histgrams. This currently breaks the presubmit. NOPRESUBMIT=true Committed: https://crrev.com/2d743cb6137cd3719a8aef1fc4c04b6d2bb7b089 Cr-Commit-Position: refs/heads/master@{#314412}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1165 lines) Patch
D chrome/common/extensions/docs/templates/public/apps/copresenceEndpoints.html View 1 chunk +0 lines, -1 line 0 comments Download
M components/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M components/components.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D components/copresence_endpoints.gypi View 1 chunk +0 lines, -28 lines 0 comments Download
D components/copresence_endpoints/BUILD.gn View 1 chunk +0 lines, -19 lines 0 comments Download
D components/copresence_endpoints/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D components/copresence_endpoints/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D components/copresence_endpoints/copresence_endpoint.cc View 1 chunk +0 lines, -162 lines 0 comments Download
D components/copresence_endpoints/copresence_socket.h View 1 chunk +0 lines, -44 lines 0 comments Download
D components/copresence_endpoints/public/copresence_endpoint.h View 1 chunk +0 lines, -89 lines 0 comments Download
D components/copresence_endpoints/transports/bluetooth/copresence_socket_bluetooth.h View 1 chunk +0 lines, -55 lines 0 comments Download
D components/copresence_endpoints/transports/bluetooth/copresence_socket_bluetooth.cc View 1 chunk +0 lines, -94 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
D extensions/browser/api/copresence_endpoints/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D extensions/browser/api/copresence_endpoints/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D extensions/browser/api/copresence_endpoints/copresence_endpoint_resource.h View 1 chunk +0 lines, -49 lines 0 comments Download
D extensions/browser/api/copresence_endpoints/copresence_endpoint_resource.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D extensions/browser/api/copresence_endpoints/copresence_endpoints_api.h View 1 chunk +0 lines, -111 lines 0 comments Download
D extensions/browser/api/copresence_endpoints/copresence_endpoints_api.cc View 1 chunk +0 lines, -336 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/common/api/_api_features.json View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D extensions/common/api/copresence_endpoints.idl View 1 chunk +0 lines, -99 lines 0 comments Download
M extensions/common/api/schemas.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M extensions/extensions.gyp View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (5 generated)
rkc
5 years, 10 months ago (2015-02-02 22:06:56 UTC) #1
Ilya Sherman
I assume you only wanted me to review extensions/browser/extension_function_histogram_value.h. Please run the script to update ...
5 years, 10 months ago (2015-02-02 22:12:50 UTC) #2
not at google - send to devlin
lgtm
5 years, 10 months ago (2015-02-02 22:27:00 UTC) #3
rkc
On 2015/02/02 22:12:50, Ilya Sherman wrote: > I assume you only wanted me to review ...
5 years, 10 months ago (2015-02-02 22:54:11 UTC) #4
xiyuan
lgtm
5 years, 10 months ago (2015-02-02 22:56:34 UTC) #5
Ilya Sherman
histograms lgtm
5 years, 10 months ago (2015-02-03 00:17:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895783002/20001
5 years, 10 months ago (2015-02-03 17:30:50 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja_ng/builds/6832)
5 years, 10 months ago (2015-02-03 17:33:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895783002/40001
5 years, 10 months ago (2015-02-03 18:36:15 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/40123)
5 years, 10 months ago (2015-02-03 18:42:25 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895783002/40001
5 years, 10 months ago (2015-02-03 21:00:14 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-03 21:59:05 UTC) #17
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 22:00:22 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2d743cb6137cd3719a8aef1fc4c04b6d2bb7b089
Cr-Commit-Position: refs/heads/master@{#314412}

Powered by Google App Engine
This is Rietveld 408576698