Fix It2Me Host doesn't kill the native process after canceling a share

remoting/webapp/crd/js/it2me_host_facade.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Class to communicate with the It2me Host component via Native Messaging.
  */
 
-'use strict';
-
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
+(function() {
+
+'use strict';
+
 /**
  * @constructor
+ * @implements {base.Disposable}
  */
 remoting.It2MeHostFacade = function() {
-  /**
-   * @type {number}
-   * @private
-   */
+  /** @private {number} */
   this.nextId_ = 0;
 
-  /**
-   * @type {?chrome.runtime.Port}
-   * @private
-   */
+  /** @private {?chrome.runtime.Port} */
   this.port_ = null;
 
-  /**
-   * @type {string}
-   * @private
-   */
+  /** @private {string} */
   this.accessCode_ = '';
 
-  /**
-   * @type {number}
-   * @private
-   */
+  /** @private {number} */
   this.accessCodeLifetime_ = 0;
 
-  /**
-   * @type {string}
-   * @private
-   */
+  /** @private {string} */
   this.clientId_ = '';
 
-  /**
-   * @type {boolean}
-   * @private
-   */
+  /** @private {boolean} */
   this.initialized_ = false;
 
+  /** @private {base.Disposables} */
+  this.eventHooks_ = null;
+
   /**
    * @type {?function():void}
  * @private
    */
   this.onInitialized_ = function() {};
 
   /**
    * Called if Native Messaging host has failed to start.
    * @private
    * */
@@ skipping 13 matching lines @@
    */
   this.onStateChanged_ = function() {};
 
   /**
    * @type {?function(boolean):void}
    * @private
    */
   this.onNatPolicyChanged_ = function() {};
 };
 
+remoting.It2MeHostFacade.prototype.dispose = function() {
+  base.dispose(this.eventHooks_);
+  this.eventHooks_ = null;
+  if (this.port_) {
+    this.port_.disconnect();
+    this.port_ = null;
+  }
+};
+
 /**
  * Sets up connection to the Native Messaging host process and exchanges
  * 'hello' messages. If Native Messaging is not supported or if the it2me
  * native messaging host is not installed, onInitializationFailed is invoked.
  * Otherwise, onInitialized is invoked.
  *
  * @param {function(*=):void} onInitialized Called after successful
  *     initialization.
  * @param {function(*=):void} onInitializationFailed Called if cannot connect to
  *     the native messaging host.
  * @return {void}
  */
 remoting.It2MeHostFacade.prototype.initialize =
     function(onInitialized, onInitializationFailed) {
   this.onInitialized_ = onInitialized;
   this.onInitializationFailed_ = onInitializationFailed;
 
   try {
     this.port_ = chrome.runtime.connectNative(
         'com.google.chrome.remote_assistance');
-    this.port_.onMessage.addListener(this.onIncomingMessage_.bind(this));
-    this.port_.onDisconnect.addListener(this.onHostDisconnect_.bind(this));
+    this.eventHooks_ = new base.Disposables(
+        new base.ChromeEventHook(this.port_.onMessage,
+                                 this.onIncomingMessage_.bind(this)),
+        new base.ChromeEventHook(this.port_.onDisconnect,
+                                 this.onHostDisconnect_.bind(this)));
     this.port_.postMessage({type: 'hello'});
   } catch (/** @type {*} */ err) {
     console.log('Native Messaging initialization failed: ', err);
     onInitializationFailed();
     return;
   }
 };
 
 /**
  * @param {string} email The user's email address.
@@ skipping 201 matching lines @@
     // the host binary cannot be found we get the "Native host has exited"
     // error.
     console.log('Native Messaging initialization failed: ' +
                 chrome.runtime.lastError.message);
     this.onInitializationFailed_();
   } else {
     console.error('Native Messaging port disconnected.');
     this.port_ = null;
     this.onError_(remoting.Error.UNEXPECTED);
   }
-}
+};
+
+})();