Fix It2Me Host doesn't kill the native process after canceling a share

remoting/webapp/crd/js/host_session.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Class handling creation and teardown of a remoting host session.
  *
  * This abstracts a <embed> element and controls the plugin which does the
  * actual remoting work.  There should be no UI code inside this class.  It
  * should be purely thought of as a controller of sorts.
  */
 
-'use strict';
-
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
+(function() {
+
+'use strict';
+
 /**
  * @constructor
+ * @implements {base.Disposable}
  */
 remoting.HostSession = function() {
   /** @type {remoting.It2MeHostFacade} @private */
   this.hostFacade_ = null;
 };
 
+})();

[kelvinp, 2015/02/04 01:38:10]

JsCompile cannot handle enums (remoting.HostSession.State) defined inside an
anonymous function, thus the abrupt ending of the function here.

[Sergey Ulanov, 2015/02/04 19:52:46]

I didn't have any problems with it inside dns_blackhole_checker.js:
https://code.google.com/p/chromium/codesearch#chromium/src/remoting/webapp/cr...

[Jamie, 2015/02/04 21:02:39]

Alternatively, you could get rid of the IIFE for this file, since it doesn't
declare anything at global scope.

[kelvinp, 2015/02/04 21:36:15]

This is because BlackholeState is not referenced anywhere outside of that file. 
But remoting.HostSession.State is referenced in this file. Removing the IIFE for
now.

+
 // Note that these values are copied directly from host_script_object.h and
 // must be kept in sync.
 /** @enum {number} */
 remoting.HostSession.State = {
   UNKNOWN: -1,
   DISCONNECTED: 0,
   STARTING: 1,
   REQUESTED_ACCESS_CODE: 2,
   RECEIVED_ACCESS_CODE: 3,
   CONNECTED: 4,
   DISCONNECTING: 5,
   ERROR: 6,
   INVALID_DOMAIN_ERROR: 7
 };
 
+(function() {
+
+remoting.HostSession.prototype.dispose = function() {
+  base.dispose(this.hostFacade_);
+  this.hostFacade_ = null;
+};
+
 /**
  * @param {string} stateString The string representation of the host state.
  * @return {remoting.HostSession.State} The HostSession.State enum value
  *     corresponding to stateString.
  */
 remoting.HostSession.State.fromString = function(stateString) {
   if (!remoting.HostSession.State.hasOwnProperty(stateString)) {
     console.error('Unexpected HostSession.State string: ', stateString);
     return remoting.HostSession.State.UNKNOWN;
   }
   return remoting.HostSession.State[stateString];
-}
+};
 
 /**
  * Initiates a connection.
  * @param {remoting.It2MeHostFacade} hostFacade It2Me host facade to use.
  * @param {string} email The user's email address.
  * @param {string} accessToken A valid OAuth2 access token.
  * @param {function(remoting.HostSession.State):void} onStateChanged
  *     Callback for notifications of changes to the host plugin's state.
  * @param {function(boolean):void} onNatTraversalPolicyChanged Callback
  *     for notification of changes to the NAT traversal policy.
@@ skipping 43 matching lines @@
   return this.hostFacade_.getClient();
 };
 
 /**
  * Disconnect the it2me session.
  * @return {void} Nothing.
  */
 remoting.HostSession.prototype.disconnect = function() {
   this.hostFacade_.disconnect();
 };
+
+})();