Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 895723003: Add MetadataCacheSetStorage implementation for LRUCache. (Closed)

Created:
5 years, 10 months ago by hirono
Modified:
5 years, 10 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Add MetadataCacheSetStorage implementation for LRUCache. BUG=410766 TEST=None R=yawano@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/f2bf2b08efce4cea5bae6e8c24e861cb4056d02d

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix JSDoc. #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -1 line) Patch
M ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set.js View 1 2 chunks +45 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
hirono
PTAL? Thanks!
5 years, 10 months ago (2015-02-03 01:30:50 UTC) #2
yawano
lgtm with nit. https://codereview.chromium.org/895723003/diff/1/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set.js File ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set.js (right): https://codereview.chromium.org/895723003/diff/1/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set.js#newcode199 ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set.js:199: * @param {!LRUCache<MetadataCacheItem>} cache LRUCache. nit: ...
5 years, 10 months ago (2015-02-03 01:36:45 UTC) #3
hirono
Thanks! https://codereview.chromium.org/895723003/diff/1/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set.js File ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set.js (right): https://codereview.chromium.org/895723003/diff/1/ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set.js#newcode199 ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set.js:199: * @param {!LRUCache<MetadataCacheItem>} cache LRUCache. On 2015/02/03 01:36:44, ...
5 years, 10 months ago (2015-02-03 01:39:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895723003/20001
5 years, 10 months ago (2015-02-03 01:40:58 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (None)
5 years, 10 months ago (2015-02-03 03:39:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895723003/40001
5 years, 10 months ago (2015-02-03 03:50:12 UTC) #10
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/f2bf2b08efce4cea5bae6e8c24e861cb4056d02d Cr-Commit-Position: refs/heads/master@{#314271}
5 years, 10 months ago (2015-02-03 05:19:10 UTC) #11
hirono
5 years, 10 months ago (2015-02-03 05:19:19 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
f2bf2b08efce4cea5bae6e8c24e861cb4056d02d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698