Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: fpdfsdk/src/fpdfview_embeddertest.cpp

Issue 895713003: Merge to XFA: Add embedder test for fix to bug_452455. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | testing/resources/bug_452455.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/src/fpdfview_embeddertest.cpp
diff --git a/fpdfsdk/src/fpdfview_embeddertest.cpp b/fpdfsdk/src/fpdfview_embeddertest.cpp
index 4827f76839569551ea87c92415c490e9baba41f7..083925ff61697f2fa5ffb561f2204624ad309e49 100644
--- a/fpdfsdk/src/fpdfview_embeddertest.cpp
+++ b/fpdfsdk/src/fpdfview_embeddertest.cpp
@@ -177,7 +177,13 @@ TEST_F(FPDFViewEmbeddertest, NamedDestsByName) {
}
// The following tests pass if the document opens without crashing.
-TEST_F(FPDFViewEmbeddertest, Crashers) {
+TEST_F(FPDFViewEmbeddertest, Crasher1) {
// XFA branch detects this document as bad.
EXPECT_FALSE(OpenDocument("testing/resources/bug_451830.pdf"));
}
+
+TEST_F(FPDFViewEmbeddertest, Crasher2) {
+ EXPECT_TRUE(OpenDocument("testing/resources/bug_452455.pdf"));
+ FPDF_PAGE page = LoadPage(0);
+ EXPECT_NE(nullptr, page);
+}
« no previous file with comments | « no previous file | testing/resources/bug_452455.in » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698