Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Issue 8957007: Change the heap file names to be Cleanup'ed in third_party/tcmalloc/chromium. (Closed)

Created:
9 years ago by Dai Mikurube (NOT FULLTIME)
Modified:
9 years ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Change the heap file names to be Cleanup'ed in third_party/tcmalloc/chromium. In spite of Chromium's changing heap file names dumped in heap-profiler.cc:DumpProfileLocked(), the file names cleaned-up in heap-profile-table.cc:HeapProfileTable::CleanupOldProfiles are not modified. (See the difference between third_party/tcmalloc/chromium/src/heap-profiler.cc and .../vendor/src/heap-profiler.cc) This patch is originally from http://codereview.chromium.org/7865021/. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114777

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/tcmalloc/chromium/src/heap-profile-table.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Dai Mikurube (NOT FULLTIME)
Hi, Found a wrong-like behavior around file clean-up in the process of working around memory ...
9 years ago (2011-12-15 13:28:30 UTC) #1
Alexander Potapenko
LGTM Thanks for taking care of this!
9 years ago (2011-12-15 13:33:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmikurube@chromium.org/8957007/1
9 years ago (2011-12-16 05:27:10 UTC) #3
Dai Mikurube (NOT FULLTIME)
Hi Alexander, Thank you! I've checked the commit box.
9 years ago (2011-12-16 05:29:29 UTC) #4
commit-bot: I haz the power
9 years ago (2011-12-16 07:02:30 UTC) #5
Change committed as 114777

Powered by Google App Engine
This is Rietveld 408576698