Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Side by Side Diff: src/ppc/full-codegen-ppc.cc

Issue 895693002: Fix issue with multiple properties and emit store. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: git rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips64/full-codegen-mips64.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_PPC 7 #if V8_TARGET_ARCH_PPC
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1700 matching lines...) Expand 10 before | Expand all | Expand 10 after
1711 break; 1711 break;
1712 case ObjectLiteral::Property::PROTOTYPE: 1712 case ObjectLiteral::Property::PROTOTYPE:
1713 // Duplicate receiver on stack. 1713 // Duplicate receiver on stack.
1714 __ LoadP(r3, MemOperand(sp)); 1714 __ LoadP(r3, MemOperand(sp));
1715 __ push(r3); 1715 __ push(r3);
1716 VisitForStackValue(value); 1716 VisitForStackValue(value);
1717 DCHECK(property->emit_store()); 1717 DCHECK(property->emit_store());
1718 __ CallRuntime(Runtime::kInternalSetPrototype, 2); 1718 __ CallRuntime(Runtime::kInternalSetPrototype, 2);
1719 break; 1719 break;
1720 case ObjectLiteral::Property::GETTER: 1720 case ObjectLiteral::Property::GETTER:
1721 accessor_table.lookup(key)->second->getter = value; 1721 if (property->emit_store()) {
1722 accessor_table.lookup(key)->second->getter = value;
1723 }
1722 break; 1724 break;
1723 case ObjectLiteral::Property::SETTER: 1725 case ObjectLiteral::Property::SETTER:
1724 accessor_table.lookup(key)->second->setter = value; 1726 if (property->emit_store()) {
1727 accessor_table.lookup(key)->second->setter = value;
1728 }
1725 break; 1729 break;
1726 } 1730 }
1727 } 1731 }
1728 1732
1729 // Emit code to define accessors, using only a single call to the runtime for 1733 // Emit code to define accessors, using only a single call to the runtime for
1730 // each pair of corresponding getters and setters. 1734 // each pair of corresponding getters and setters.
1731 for (AccessorTable::Iterator it = accessor_table.begin(); 1735 for (AccessorTable::Iterator it = accessor_table.begin();
1732 it != accessor_table.end(); ++it) { 1736 it != accessor_table.end(); ++it) {
1733 __ LoadP(r3, MemOperand(sp)); // Duplicate receiver. 1737 __ LoadP(r3, MemOperand(sp)); // Duplicate receiver.
1734 __ push(r3); 1738 __ push(r3);
(...skipping 3546 matching lines...) Expand 10 before | Expand all | Expand 10 after
5281 return ON_STACK_REPLACEMENT; 5285 return ON_STACK_REPLACEMENT;
5282 } 5286 }
5283 5287
5284 DCHECK(interrupt_address == 5288 DCHECK(interrupt_address ==
5285 isolate->builtins()->OsrAfterStackCheck()->entry()); 5289 isolate->builtins()->OsrAfterStackCheck()->entry());
5286 return OSR_AFTER_STACK_CHECK; 5290 return OSR_AFTER_STACK_CHECK;
5287 } 5291 }
5288 } 5292 }
5289 } // namespace v8::internal 5293 } // namespace v8::internal
5290 #endif // V8_TARGET_ARCH_PPC 5294 #endif // V8_TARGET_ARCH_PPC
OLDNEW
« no previous file with comments | « src/mips64/full-codegen-mips64.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698