Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: src/mips64/full-codegen-mips64.cc

Issue 895693002: Fix issue with multiple properties and emit store. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: git rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | src/ppc/full-codegen-ppc.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS64 7 #if V8_TARGET_ARCH_MIPS64
8 8
9 // Note on Mips implementation: 9 // Note on Mips implementation:
10 // 10 //
(...skipping 1722 matching lines...) Expand 10 before | Expand all | Expand 10 after
1733 break; 1733 break;
1734 case ObjectLiteral::Property::PROTOTYPE: 1734 case ObjectLiteral::Property::PROTOTYPE:
1735 // Duplicate receiver on stack. 1735 // Duplicate receiver on stack.
1736 __ ld(a0, MemOperand(sp)); 1736 __ ld(a0, MemOperand(sp));
1737 __ push(a0); 1737 __ push(a0);
1738 VisitForStackValue(value); 1738 VisitForStackValue(value);
1739 DCHECK(property->emit_store()); 1739 DCHECK(property->emit_store());
1740 __ CallRuntime(Runtime::kInternalSetPrototype, 2); 1740 __ CallRuntime(Runtime::kInternalSetPrototype, 2);
1741 break; 1741 break;
1742 case ObjectLiteral::Property::GETTER: 1742 case ObjectLiteral::Property::GETTER:
1743 accessor_table.lookup(key)->second->getter = value; 1743 if (property->emit_store()) {
1744 accessor_table.lookup(key)->second->getter = value;
1745 }
1744 break; 1746 break;
1745 case ObjectLiteral::Property::SETTER: 1747 case ObjectLiteral::Property::SETTER:
1746 accessor_table.lookup(key)->second->setter = value; 1748 if (property->emit_store()) {
1749 accessor_table.lookup(key)->second->setter = value;
1750 }
1747 break; 1751 break;
1748 } 1752 }
1749 } 1753 }
1750 1754
1751 // Emit code to define accessors, using only a single call to the runtime for 1755 // Emit code to define accessors, using only a single call to the runtime for
1752 // each pair of corresponding getters and setters. 1756 // each pair of corresponding getters and setters.
1753 for (AccessorTable::Iterator it = accessor_table.begin(); 1757 for (AccessorTable::Iterator it = accessor_table.begin();
1754 it != accessor_table.end(); 1758 it != accessor_table.end();
1755 ++it) { 1759 ++it) {
1756 __ ld(a0, MemOperand(sp)); // Duplicate receiver. 1760 __ ld(a0, MemOperand(sp)); // Duplicate receiver.
(...skipping 3615 matching lines...) Expand 10 before | Expand all | Expand 10 after
5372 Assembler::target_address_at(pc_immediate_load_address)) == 5376 Assembler::target_address_at(pc_immediate_load_address)) ==
5373 reinterpret_cast<uint64_t>( 5377 reinterpret_cast<uint64_t>(
5374 isolate->builtins()->OsrAfterStackCheck()->entry())); 5378 isolate->builtins()->OsrAfterStackCheck()->entry()));
5375 return OSR_AFTER_STACK_CHECK; 5379 return OSR_AFTER_STACK_CHECK;
5376 } 5380 }
5377 5381
5378 5382
5379 } } // namespace v8::internal 5383 } } // namespace v8::internal
5380 5384
5381 #endif // V8_TARGET_ARCH_MIPS64 5385 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | src/ppc/full-codegen-ppc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698