Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Side by Side Diff: src/mips/full-codegen-mips.cc

Issue 895693002: Fix issue with multiple properties and emit store. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: git rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS 7 #if V8_TARGET_ARCH_MIPS
8 8
9 // Note on Mips implementation: 9 // Note on Mips implementation:
10 // 10 //
(...skipping 1725 matching lines...) Expand 10 before | Expand all | Expand 10 after
1736 break; 1736 break;
1737 case ObjectLiteral::Property::PROTOTYPE: 1737 case ObjectLiteral::Property::PROTOTYPE:
1738 // Duplicate receiver on stack. 1738 // Duplicate receiver on stack.
1739 __ lw(a0, MemOperand(sp)); 1739 __ lw(a0, MemOperand(sp));
1740 __ push(a0); 1740 __ push(a0);
1741 VisitForStackValue(value); 1741 VisitForStackValue(value);
1742 DCHECK(property->emit_store()); 1742 DCHECK(property->emit_store());
1743 __ CallRuntime(Runtime::kInternalSetPrototype, 2); 1743 __ CallRuntime(Runtime::kInternalSetPrototype, 2);
1744 break; 1744 break;
1745 case ObjectLiteral::Property::GETTER: 1745 case ObjectLiteral::Property::GETTER:
1746 accessor_table.lookup(key)->second->getter = value; 1746 if (property->emit_store()) {
1747 accessor_table.lookup(key)->second->getter = value;
1748 }
1747 break; 1749 break;
1748 case ObjectLiteral::Property::SETTER: 1750 case ObjectLiteral::Property::SETTER:
1749 accessor_table.lookup(key)->second->setter = value; 1751 if (property->emit_store()) {
1752 accessor_table.lookup(key)->second->setter = value;
1753 }
1750 break; 1754 break;
1751 } 1755 }
1752 } 1756 }
1753 1757
1754 // Emit code to define accessors, using only a single call to the runtime for 1758 // Emit code to define accessors, using only a single call to the runtime for
1755 // each pair of corresponding getters and setters. 1759 // each pair of corresponding getters and setters.
1756 for (AccessorTable::Iterator it = accessor_table.begin(); 1760 for (AccessorTable::Iterator it = accessor_table.begin();
1757 it != accessor_table.end(); 1761 it != accessor_table.end();
1758 ++it) { 1762 ++it) {
1759 __ lw(a0, MemOperand(sp)); // Duplicate receiver. 1763 __ lw(a0, MemOperand(sp)); // Duplicate receiver.
(...skipping 3608 matching lines...) Expand 10 before | Expand all | Expand 10 after
5368 Assembler::target_address_at(pc_immediate_load_address)) == 5372 Assembler::target_address_at(pc_immediate_load_address)) ==
5369 reinterpret_cast<uint32_t>( 5373 reinterpret_cast<uint32_t>(
5370 isolate->builtins()->OsrAfterStackCheck()->entry())); 5374 isolate->builtins()->OsrAfterStackCheck()->entry()));
5371 return OSR_AFTER_STACK_CHECK; 5375 return OSR_AFTER_STACK_CHECK;
5372 } 5376 }
5373 5377
5374 5378
5375 } } // namespace v8::internal 5379 } } // namespace v8::internal
5376 5380
5377 #endif // V8_TARGET_ARCH_MIPS 5381 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698