Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 895673004: Revert of Unify GPU raster and accelerated canvas blacklists on Android. (Closed)

Created:
5 years, 10 months ago by aelias_OOO_until_Jul13
Modified:
5 years, 10 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, Justin Novosad, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Unify GPU raster and accelerated canvas blacklists on Android. (patchset #3 id:40001 of https://codereview.chromium.org/877343008/) Reason for revert: Causes blank screen on Daisy boot (ChromeOS T604) BUG=454547 Original issue's description: > Unify GPU raster and accelerated canvas blacklists on Android. > > Accelerated canvas and GPU raster both use the same Skia codepaths and > have generally displayed the same bugs. It doesn't make sense to > blacklist one but not the other. Since GPU raster sees more usage than > canvas nowadays, and I researched GPU raster compatibility as part of > https://codereview.chromium.org/760053003, it makes sense to fold canvas > into the same blacklist. > > This immediately fixes an Adreno 225 canvas bug which slipped through a > driver-reported-version based blacklist, which is apparently unreliable > and which I deleted in this patch. More generally it also should avoid > this kind of issue in the future. > > BUG=453283 > NOTRY=true > > Committed: https://crrev.com/044dfb80b1f612f3c84b35182db0f9b4d93e086c > Cr-Commit-Position: refs/heads/master@{#313813} TBR=zmo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=453283 Committed: https://crrev.com/259fd3ded173e9c932bf2f2dcdb4e11f5aa959d9 Cr-Commit-Position: refs/heads/master@{#314239}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M gpu/config/software_rendering_list_json.cc View 5 chunks +21 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
aelias_OOO_until_Jul13
Created Revert of Unify GPU raster and accelerated canvas blacklists on Android.
5 years, 10 months ago (2015-02-03 01:38:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895673004/1
5 years, 10 months ago (2015-02-03 01:39:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 01:41:57 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 01:44:21 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/259fd3ded173e9c932bf2f2dcdb4e11f5aa959d9
Cr-Commit-Position: refs/heads/master@{#314239}

Powered by Google App Engine
This is Rietveld 408576698