Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: chrome/browser/password_manager/native_backend_kwallet_x.cc

Issue 895653002: Serialize date_created in PasswordStoreX properly (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: KWallet implementation Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/native_backend_kwallet_x.cc
diff --git a/chrome/browser/password_manager/native_backend_kwallet_x.cc b/chrome/browser/password_manager/native_backend_kwallet_x.cc
index 55958b1e03eea04a3250959d0ec984c98673c9d8..4f8704fa851050a362911feca98a0ab61c98a28f 100644
--- a/chrome/browser/password_manager/native_backend_kwallet_x.cc
+++ b/chrome/browser/password_manager/native_backend_kwallet_x.cc
@@ -722,7 +722,7 @@ void NativeBackendKWallet::SerializeValue(
pickle->WriteBool(form->ssl_valid);
pickle->WriteBool(form->preferred);
pickle->WriteBool(form->blacklisted_by_user);
- pickle->WriteInt64(form->date_created.ToTimeT());
+ pickle->WriteInt64(form->date_created.ToInternalValue());
pickle->WriteInt(form->type);
pickle->WriteInt(form->times_used);
autofill::SerializeFormData(form->form_data, pickle);
@@ -801,7 +801,6 @@ bool NativeBackendKWallet::DeserializeValueSize(
return false;
}
form->scheme = static_cast<PasswordForm::Scheme>(scheme);
- form->date_created = base::Time::FromTimeT(date_created);
if (version > 1) {
if (!iter.ReadInt(&type) ||
@@ -832,6 +831,12 @@ bool NativeBackendKWallet::DeserializeValueSize(
}
}
+ if (version > 4) {
+ form->date_created = base::Time::FromInternalValue(date_created);
+ } else {
+ form->date_created = base::Time::FromTimeT(date_created);
+ }
+
forms->push_back(form.release());
}

Powered by Google App Engine
This is Rietveld 408576698