Serialize date_created in PasswordStoreX properly

chrome/browser/password_manager/native_backend_libsecret.cc

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/native_backend_libsecret.h"
 
 #include <dlfcn.h>
 #include <list>
 
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/metrics/histogram.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 
 using autofill::PasswordForm;
 using base::UTF8ToUTF16;
 using base::UTF16ToUTF8;
 
 namespace {
 const char kEmptyString[] = "";
+const int kMaxPossibleTimeTValue = INT_MAX;

[vabr (Chromium), 2015/02/02 17:01:18]

What about std::numeric_limits<int>::max() ?

[dvadym, 2015/02/03 11:53:49]

Done.

 }
 
 typeof(&::secret_password_store_sync)
     LibsecretLoader::secret_password_store_sync;
 typeof(&::secret_service_search_sync)
     LibsecretLoader::secret_service_search_sync;
 typeof(&::secret_password_clear_sync)
     LibsecretLoader::secret_password_clear_sync;
 typeof(&::secret_item_get_secret) LibsecretLoader::secret_item_get_secret;
 typeof(&::secret_value_get_text) LibsecretLoader::secret_value_get_text;
@@ skipping 123 matching lines @@
       UTF8ToUTF16(GetStringFromAttributes(attrs, "password_element"));
   form->submit_element =
       UTF8ToUTF16(GetStringFromAttributes(attrs, "submit_element"));
   form->signon_realm = GetStringFromAttributes(attrs, "signon_realm");
   form->ssl_valid = GetUintFromAttributes(attrs, "ssl_valid");
   form->preferred = GetUintFromAttributes(attrs, "preferred");
   int64 date_created = 0;
   bool date_ok = base::StringToInt64(
       GetStringFromAttributes(attrs, "date_created"), &date_created);
   DCHECK(date_ok);
-  form->date_created = base::Time::FromTimeT(date_created);
+  // In past date_created was stored as time_t. We can distinguish between
+  // them by taking into consideration that INT_MAX correspond to
+  // 2038 year in time_t and internal values of base::Time are much bigger.
+  form->date_created = date_created < kMaxPossibleTimeTValue
+                           ? base::Time::FromTimeT(date_created)
+                           : base::Time::FromInternalValue(date_created);
   form->blacklisted_by_user =
       GetUintFromAttributes(attrs, "blacklisted_by_user");
   form->type =
       static_cast<PasswordForm::Type>(GetUintFromAttributes(attrs, "type"));
   form->times_used = GetUintFromAttributes(attrs, "times_used");
   form->scheme =
       static_cast<PasswordForm::Scheme>(GetUintFromAttributes(attrs, "scheme"));
   int64 date_synced = 0;
   base::StringToInt64(GetStringFromAttributes(attrs, "date_synced"),
                       &date_synced);
@@ skipping 212 matching lines @@
     g_error_free(error);
     if (found)
       g_list_free(found);
     return;
   }
 
   ConvertFormList(found, &lookup_form, forms);
 }
 
 bool NativeBackendLibsecret::RawAddLogin(const PasswordForm& form) {
-  time_t date_created = form.date_created.ToTimeT();
+  int64 date_created = form.date_created.ToInternalValue();
   // If we are asked to save a password with 0 date, use the current time.
-  // We don't want to actually save passwords as though on January 1, 1970.
+  // We don't want to actually save passwords as though on January 1, 1601.
   if (!date_created)
-    date_created = time(nullptr);
+    date_created = base::Time::Now().ToInternalValue();
   int64 date_synced = form.date_synced.ToInternalValue();
   GError* error = nullptr;
   secret_password_store_sync(
       &kLibsecretSchema,
       nullptr,                     // Default collection.
       form.origin.spec().c_str(),  // Display name.
       UTF16ToUTF8(form.password_value).c_str(),
       nullptr,  // no cancellable ojbect
       &error, "origin_url", form.origin.spec().c_str(), "action_url",
       form.action.spec().c_str(), "username_element",
@@ skipping 174 matching lines @@
   return true;
 }
 
 std::string NativeBackendLibsecret::GetProfileSpecificAppString(
     LocalProfileId id) {
   // Originally, the application string was always just "chrome" and used only
   // so that we had *something* to search for since GNOME Keyring won't search
   // for nothing. Now we use it to distinguish passwords for different profiles.
   return base::StringPrintf("%s-%d", kLibsecretAppString, id);
 }