Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 895633005: Optimize the ripple effect on the navigation bar in Files app. (Closed)

Created:
5 years, 10 months ago by mtomasz
Modified:
5 years, 10 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Optimize the ripple effect on the navigation bar in Files app. Due to slow querySelector (7ms) in the command handler, the ripple was far from smooth. This CL replaces querySelector with getElementsByClassName which is around 20 times faster. TEST=Tested manually that the ripple is smooth. BUG=455055 Committed: https://crrev.com/489a61ed8f0ed4538a856572ff9979a6f3e01b12 Cr-Commit-Position: refs/heads/master@{#314499}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M ui/file_manager/file_manager/foreground/js/file_manager_commands.js View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mtomasz
@fukino: PTAL. Thanks.
5 years, 10 months ago (2015-02-04 03:33:02 UTC) #2
fukino
Wow! Thanks!!! lgtm.
5 years, 10 months ago (2015-02-04 03:34:47 UTC) #3
mtomasz
Thanks!
5 years, 10 months ago (2015-02-04 03:40:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895633005/1
5 years, 10 months ago (2015-02-04 03:40:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 04:09:55 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 04:11:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/489a61ed8f0ed4538a856572ff9979a6f3e01b12
Cr-Commit-Position: refs/heads/master@{#314499}

Powered by Google App Engine
This is Rietveld 408576698