Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 895633004: Update harmony Object.prototype.toString to 2/2/2015 spec (Closed)

Created:
5 years, 10 months ago by caitp (gmail)
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Update harmony Object.prototype.toString to 2/2/2015 spec - Removes special handling of non-string @@toStringTag values (use builtinTag) - Removes special handling of @@toStringTags which match [[Class]] names (remove ~ prefix) BUG=v8:3502 R=arv@chromium.org LOG=N Committed: https://crrev.com/858b9b6a7e6c86464e7bb8ca87f8649ca9d1cdba Cr-Commit-Position: refs/heads/master@{#26411}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -29 lines) Patch
M src/harmony-tostring.js View 2 chunks +1 line, -18 lines 0 comments Download
M test/mjsunit/es6/array-tostring.js View 4 chunks +5 lines, -5 lines 0 comments Download
M test/mjsunit/es6/object-tostring.js View 5 chunks +6 lines, -6 lines 1 comment Download

Messages

Total messages: 9 (1 generated)
caitp (gmail)
PTAL -- pretty trivial, might be some comments still need to be removed in tests ...
5 years, 10 months ago (2015-02-03 15:29:24 UTC) #1
caitp (gmail)
On 2015/02/03 15:29:24, caitp wrote: > PTAL -- pretty trivial, might be some comments still ...
5 years, 10 months ago (2015-02-03 15:30:05 UTC) #2
arv (Not doing code reviews)
LGTM Do you want to do the .cc in a different CL?
5 years, 10 months ago (2015-02-03 15:32:23 UTC) #3
caitp (gmail)
On 2015/02/03 15:32:23, arv wrote: > LGTM > > Do you want to do the ...
5 years, 10 months ago (2015-02-03 15:33:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895633004/1
5 years, 10 months ago (2015-02-03 15:40:45 UTC) #6
caitp (gmail)
https://codereview.chromium.org/895633004/diff/1/test/mjsunit/es6/object-tostring.js File test/mjsunit/es6/object-tostring.js (right): https://codereview.chromium.org/895633004/diff/1/test/mjsunit/es6/object-tostring.js#newcode5 test/mjsunit/es6/object-tostring.js:5: // Flags: --harmony-tostring --allow-natives-syntax hmmm, I thought I was ...
5 years, 10 months ago (2015-02-03 15:49:54 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 17:45:13 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 17:45:27 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/858b9b6a7e6c86464e7bb8ca87f8649ca9d1cdba
Cr-Commit-Position: refs/heads/master@{#26411}

Powered by Google App Engine
This is Rietveld 408576698