Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 895623003: Reland Ensure WebView notifies desktop automation on creation, destruction, and change (Closed)

Created:
5 years, 10 months ago by David Tseng
Modified:
5 years, 10 months ago
Reviewers:
tfarina, dmazzoni, sky
CC:
chromium-reviews, extensions-reviews_chromium.org, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland Ensure WebView notifies desktop automation on creation, destruction, and change Original issue https://codereview.chromium.org/880063002 TBR=dtseng@chromium.org Committed: https://crrev.com/4a61275d7b2708d4aca1e1c4975739424a379fc3 Cr-Commit-Position: refs/heads/master@{#314378}

Patch Set 1 #

Patch Set 2 : Must have parent. #

Patch Set 3 : #

Patch Set 4 : Don't fire native event #

Patch Set 5 : Is destroying. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -96 lines) Patch
M chrome/browser/resources/chromeos/chromevox/common/chrome_extension_externs.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/editable_text_base.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js View 3 chunks +21 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 5 chunks +32 lines, -51 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs View 2 chunks +17 lines, -18 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js View 1 chunk +8 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/testing/mock_tts.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extensions/automation/automation_node.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/extension_js_browser_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/extension_load_waiter_one_shot.h View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/views/accessibility/ax_aura_obj_cache.h View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download
M ui/views/accessibility/ax_aura_obj_cache.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/accessibility/ax_widget_obj_wrapper.cc View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M ui/views/controls/webview/webview.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/webview/webview.cc View 1 2 3 7 chunks +15 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895623003/20001
5 years, 10 months ago (2015-02-02 20:39:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895623003/60001
5 years, 10 months ago (2015-02-02 23:22:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895623003/80001
5 years, 10 months ago (2015-02-03 19:08:50 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 10 months ago (2015-02-03 19:13:29 UTC) #9
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/4a61275d7b2708d4aca1e1c4975739424a379fc3 Cr-Commit-Position: refs/heads/master@{#314378}
5 years, 10 months ago (2015-02-03 19:14:35 UTC) #10
ccameron
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/897103002/ by ccameron@chromium.org. ...
5 years, 10 months ago (2015-02-04 21:00:55 UTC) #11
tfarina
Can this get a review next time this is relanded? This has been reverted too ...
5 years, 10 months ago (2015-02-04 21:07:26 UTC) #13
David Tseng
5 years, 10 months ago (2015-02-04 21:22:27 UTC) #14
Message was sent while issue was closed. 
Sure; this was the second time it was reverted.

On Wed, Feb 4, 2015 at 1:07 PM, <tfarina@chromium.org> wrote:

> Can this get a review next time this is relanded? This has been reverted
> too
> many times already!
>
> https://codereview.chromium.org/895623003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698