Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 895573002: Check global object behind global proxy for extensibility (Closed)

Created:
5 years, 10 months ago by Toon Verwaest
Modified:
5 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Check global object behind global proxy for extensibility BUG=454091 LOG=Y Committed: https://crrev.com/1de7dff2ef7b2dd0adf470c3ba54567330ae7cee Cr-Commit-Position: refs/heads/master@{#26380}

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M src/accessors.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +7 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-454091.js View 1 chunk +5 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Toon Verwaest
PTAL (commit if you like)
5 years, 10 months ago (2015-02-02 10:27:24 UTC) #2
Igor Sheludko
lgtm
5 years, 10 months ago (2015-02-02 10:52:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895573002/1
5 years, 10 months ago (2015-02-02 10:52:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/296)
5 years, 10 months ago (2015-02-02 10:54:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895573002/1
5 years, 10 months ago (2015-02-02 10:56:42 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/2496)
5 years, 10 months ago (2015-02-02 11:20:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895573002/20001
5 years, 10 months ago (2015-02-02 11:42:12 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-02 12:49:07 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 12:49:21 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1de7dff2ef7b2dd0adf470c3ba54567330ae7cee
Cr-Commit-Position: refs/heads/master@{#26380}

Powered by Google App Engine
This is Rietveld 408576698