Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 895543002: Oilpan: fix webkit unit tests after r189319 (df44f48). (Closed)

Created:
5 years, 10 months ago by sof
Modified:
5 years, 10 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, Timothy Loh, darktears, Steve Block, Eric Willigers, loyso (OOO)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: fix webkit unit tests after r189319 (df44f48). R=haraken BUG=358832 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189324

Patch Set 1 #

Patch Set 2 : non-Oilpan compile fix #

Patch Set 3 : tidy up RenderObjectProxy destruction #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M Source/core/animation/CompositorAnimationsTest.cpp View 1 2 5 chunks +18 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
Please take a look.
5 years, 10 months ago (2015-02-02 08:48:41 UTC) #2
haraken
LGTM, thanks for the quick fix!
5 years, 10 months ago (2015-02-02 08:51:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895543002/40001
5 years, 10 months ago (2015-02-02 09:00:03 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 09:59:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189324

Powered by Google App Engine
This is Rietveld 408576698