Issue 895533003: Revert of Disable chromevox_tests BackgroundTest.InitialFeedback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 895533003: Revert of Disable chromevox_tests BackgroundTest.InitialFeedback (Closed)

Created:
5 years, 10 months ago by David Tseng

Modified:
5 years, 10 months ago

Reviewers:

CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Disable chromevox_tests BackgroundTest.InitialFeedback (patchset #2 id:20001 of https://codereview.chromium.org/908913002/) Reason for revert: Cl which caused this flake was reverted. Original issue's description: > Disable chromevox_tests BackgroundTest.InitialFeedback > > The test attempts to monitor speech immediately after startup. Disabling for now until we can figure out why it flakes on bots. > > NOTRY=true > TBR=dtseng@chromium.org > > Committed: https://crrev.com/94007abc03dff9620d5fd64237b1fdb3c0c19957 > Cr-Commit-Position: refs/heads/master@{#315374} TBR= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/ab7392a1539409dce6691a5f26c872bf93b1edfe Cr-Commit-Position: refs/heads/master@{#315392}

Patch Set 1 #

Created: 5 years, 10 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

David Tseng

Created Revert of Disable chromevox_tests BackgroundTest.InitialFeedback

5 years, 10 months ago (2015-02-09 21:03:58 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895533003/1

5 years, 10 months ago (2015-02-09 21:04:50 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-02-09 21:06:16 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/ab7392a1539409dce6691a5f26c872bf93b1edfe
Cr-Commit-Position: refs/heads/master@{#315392}

Expand Messages | Collapse Messages