Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: sky/engine/core/rendering/RenderLayer.cpp

Issue 895483002: Remove the last remnant of paint phases. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderBox.cpp ('k') | sky/engine/core/rendering/RenderObject.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 998 matching lines...) Expand 10 before | Expand all | Expand 10 after
1009 beginTransparencyLayers(transparencyLayerContext, localPaintingInfo.root Layer, transparencyPaintDirtyRect, localPaintingInfo.subPixelAccumulation); 1009 beginTransparencyLayers(transparencyLayerContext, localPaintingInfo.root Layer, transparencyPaintDirtyRect, localPaintingInfo.subPixelAccumulation);
1010 1010
1011 // Optimize clipping for the single fragment case. 1011 // Optimize clipping for the single fragment case.
1012 bool shouldClip = localPaintingInfo.clipToDirtyRect && !foregroundRectIsEmpt y; 1012 bool shouldClip = localPaintingInfo.clipToDirtyRect && !foregroundRectIsEmpt y;
1013 if (shouldClip) 1013 if (shouldClip)
1014 clipToRect(localPaintingInfo, context, layerForegroundRect); 1014 clipToRect(localPaintingInfo, context, layerForegroundRect);
1015 1015
1016 // TODO(ojan): We probably should early return at the beginning of this func tion 1016 // TODO(ojan): We probably should early return at the beginning of this func tion
1017 // if the rect is empty. 1017 // if the rect is empty.
1018 if (!foregroundRectIsEmpty) { 1018 if (!foregroundRectIsEmpty) {
1019 PaintInfo paintInfo(context, pixelSnappedIntRect(layerForegroundRect.rec t()), PaintPhaseForeground, localPaintingInfo.rootLayer->renderer()); 1019 PaintInfo paintInfo(context, pixelSnappedIntRect(layerForegroundRect.rec t()), localPaintingInfo.rootLayer->renderer());
1020 renderer()->paint(paintInfo, layerLocation); 1020 renderer()->paint(paintInfo, layerLocation);
1021 } 1021 }
1022 1022
1023 if (shouldClip) 1023 if (shouldClip)
1024 restoreClip(context, localPaintingInfo.paintDirtyRect, layerForegroundRe ct); 1024 restoreClip(context, localPaintingInfo.paintDirtyRect, layerForegroundRe ct);
1025 } 1025 }
1026 1026
1027 static inline LayoutRect frameVisibleRect(RenderObject* renderer) 1027 static inline LayoutRect frameVisibleRect(RenderObject* renderer)
1028 { 1028 {
1029 FrameView* frameView = renderer->document().view(); 1029 FrameView* frameView = renderer->document().view();
(...skipping 642 matching lines...) Expand 10 before | Expand all | Expand 10 after
1672 } 1672 }
1673 } 1673 }
1674 1674
1675 void showLayerTree(const blink::RenderObject* renderer) 1675 void showLayerTree(const blink::RenderObject* renderer)
1676 { 1676 {
1677 if (!renderer) 1677 if (!renderer)
1678 return; 1678 return;
1679 showLayerTree(renderer->enclosingLayer()); 1679 showLayerTree(renderer->enclosingLayer());
1680 } 1680 }
1681 #endif 1681 #endif
OLDNEW
« no previous file with comments | « sky/engine/core/rendering/RenderBox.cpp ('k') | sky/engine/core/rendering/RenderObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698