Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Side by Side Diff: sky/engine/core/rendering/RenderBox.h

Issue 895483002: Remove the last remnant of paint phases. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderBlock.cpp ('k') | sky/engine/core/rendering/RenderBox.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 359 matching lines...) Expand 10 before | Expand all | Expand 10 after
370 // There are a few cases where we need to refer specifically to the availabl e physical width and available physical height. 370 // There are a few cases where we need to refer specifically to the availabl e physical width and available physical height.
371 // Relative positioning is one of those cases, since left/top offsets are ph ysical. 371 // Relative positioning is one of those cases, since left/top offsets are ph ysical.
372 LayoutUnit availableWidth() const { return availableLogicalWidth(); } 372 LayoutUnit availableWidth() const { return availableLogicalWidth(); }
373 LayoutUnit availableHeight() const { return availableLogicalHeight(IncludeMa rginBorderPadding); } 373 LayoutUnit availableHeight() const { return availableLogicalHeight(IncludeMa rginBorderPadding); }
374 374
375 virtual LayoutRect localCaretRect(InlineBox*, int caretOffset, LayoutUnit* e xtraWidthToEndOfLine = 0) override; 375 virtual LayoutRect localCaretRect(InlineBox*, int caretOffset, LayoutUnit* e xtraWidthToEndOfLine = 0) override;
376 376
377 virtual LayoutRect overflowClipRect(const LayoutPoint& location); 377 virtual LayoutRect overflowClipRect(const LayoutPoint& location);
378 LayoutRect clipRect(const LayoutPoint& location); 378 LayoutRect clipRect(const LayoutPoint& location);
379 bool pushContentsClip(PaintInfo&, const LayoutPoint& accumulatedOffset, Cont entsClipBehavior); 379 bool pushContentsClip(PaintInfo&, const LayoutPoint& accumulatedOffset, Cont entsClipBehavior);
380 void popContentsClip(PaintInfo&, PaintPhase originalPhase, const LayoutPoint & accumulatedOffset); 380 void popContentsClip(PaintInfo&, const LayoutPoint& accumulatedOffset);
381 381
382 virtual void paintObject(PaintInfo&, const LayoutPoint&) { ASSERT_NOT_REACHE D(); } 382 virtual void paintObject(PaintInfo&, const LayoutPoint&) { ASSERT_NOT_REACHE D(); }
383 virtual void paintBoxDecorationBackground(PaintInfo&, const LayoutPoint&); 383 virtual void paintBoxDecorationBackground(PaintInfo&, const LayoutPoint&);
384 384
385 // Called when a positioned object moves but doesn't necessarily change size . A simplified layout is attempted 385 // Called when a positioned object moves but doesn't necessarily change size . A simplified layout is attempted
386 // that just updates the object's position. If the size does change, the obj ect remains dirty. 386 // that just updates the object's position. If the size does change, the obj ect remains dirty.
387 bool tryLayoutDoingPositionedMovementOnly() 387 bool tryLayoutDoingPositionedMovementOnly()
388 { 388 {
389 LayoutUnit oldWidth = width(); 389 LayoutUnit oldWidth = width();
390 updateLogicalWidth(); 390 updateLogicalWidth();
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
567 if (UNLIKELY(inlineBoxWrapper() != 0)) 567 if (UNLIKELY(inlineBoxWrapper() != 0))
568 deleteLineBoxWrapper(); 568 deleteLineBoxWrapper();
569 } 569 }
570 570
571 ensureRareData().m_inlineBoxWrapper = boxWrapper; 571 ensureRareData().m_inlineBoxWrapper = boxWrapper;
572 } 572 }
573 573
574 } // namespace blink 574 } // namespace blink
575 575
576 #endif // SKY_ENGINE_CORE_RENDERING_RENDERBOX_H_ 576 #endif // SKY_ENGINE_CORE_RENDERING_RENDERBOX_H_
OLDNEW
« no previous file with comments | « sky/engine/core/rendering/RenderBlock.cpp ('k') | sky/engine/core/rendering/RenderBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698