Chromium Code Reviews

Issue 895473002: x87: Use signaling NaN for holes in fixed double arrays. (Closed)

Created:
5 years, 10 months ago by Weiliang
Modified:
5 years, 10 months ago
Reviewers:
Benedikt Meurer, Jakob Kummerow (corp), chunyang.dai, danno
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

x87: Use signaling NaN for holes in fixed double arrays. Port 9eace97bbaab72962c0fda62e5f9011a10604d0d BUG= R=chunyang.dai@intel.com Committed: https://crrev.com/c397d2951f2e78b6470e8fabf85e98b5965dad18 Cr-Commit-Position: refs/heads/master@{#26445}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Stats (+43 lines, -64 lines)
M src/x87/lithium-codegen-x87.cc View 7 chunks +39 lines, -38 lines 0 comments
M src/x87/lithium-x87.h View 1 chunk +1 line, -1 line 0 comments
M src/x87/lithium-x87.cc View 1 chunk +1 line, -1 line 0 comments
M src/x87/macro-assembler-x87.cc View 2 chunks +2 lines, -24 lines 0 comments

Messages

Total messages: 5 (1 generated)
Weiliang
PTAL. As discussed, to make buildbot green, we use this temporary solution for x87 port. ...
5 years, 10 months ago (2015-02-04 04:44:01 UTC) #2
chunyang.dai
LGTM. thanks
5 years, 10 months ago (2015-02-05 02:49:27 UTC) #3
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c397d2951f2e78b6470e8fabf85e98b5965dad18 Cr-Commit-Position: refs/heads/master@{#26445}
5 years, 10 months ago (2015-02-05 02:54:08 UTC) #4
Weiliang
5 years, 10 months ago (2015-02-05 02:54:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c397d2951f2e78b6470e8fabf85e98b5965dad18.

Powered by Google App Engine