Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 895433002: gn: Use the term 'out_dir' consistently when referring to the output directory. (Closed)

Created:
5 years, 10 months ago by tfarina
Modified:
5 years, 10 months ago
Reviewers:
scottmg, mdempsky
CC:
chromium-reviews, tfarina, brettw, mdempsky
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Use the term 'out_dir' consistently when referring to the output directory. The output directory is the same as the build directory, so let's be consistent to not confuse new users. BUG=441955 TEST=gn help args, gn help gen, gn help ls, gn help refs R=scottmg@chromium.org Committed: https://crrev.com/f575e01d05e216389f358356adcc8c46f23f36d5 Cr-Commit-Position: refs/heads/master@{#314324}

Patch Set 1 #

Total comments: 4

Patch Set 2 : build_dir #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M tools/gn/command_args.cc View 1 5 chunks +8 lines, -8 lines 0 comments Download
M tools/gn/command_gen.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/command_ls.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/command_refs.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
tfarina
https://codereview.chromium.org/895433002/diff/1/tools/gn/command_args.cc File tools/gn/command_args.cc (right): https://codereview.chromium.org/895433002/diff/1/tools/gn/command_args.cc#newcode290 tools/gn/command_args.cc:290: " enable_doom_melon=false\n" Do we bother changing this? It seems ...
5 years, 10 months ago (2015-02-02 00:55:20 UTC) #1
mdempsky
lgtm, fwiw https://codereview.chromium.org/895433002/diff/1/tools/gn/command_args.cc File tools/gn/command_args.cc (right): https://codereview.chromium.org/895433002/diff/1/tools/gn/command_args.cc#newcode290 tools/gn/command_args.cc:290: " enable_doom_melon=false\n" On 2015/02/02 00:55:20, tfarina wrote: ...
5 years, 10 months ago (2015-02-02 01:05:18 UTC) #3
scottmg
lgtm https://codereview.chromium.org/895433002/diff/1/tools/gn/command_refs.cc File tools/gn/command_refs.cc (right): https://codereview.chromium.org/895433002/diff/1/tools/gn/command_refs.cc#newcode285 tools/gn/command_refs.cc:285: "Usage: \"gn refs <build_dir> (<label_pattern>|<file>)\"") another one here
5 years, 10 months ago (2015-02-02 02:18:43 UTC) #4
tfarina
https://codereview.chromium.org/895433002/diff/1/tools/gn/command_refs.cc File tools/gn/command_refs.cc (right): https://codereview.chromium.org/895433002/diff/1/tools/gn/command_refs.cc#newcode285 tools/gn/command_refs.cc:285: "Usage: \"gn refs <build_dir> (<label_pattern>|<file>)\"") On 2015/02/02 02:18:43, scottmg ...
5 years, 10 months ago (2015-02-03 02:10:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895433002/20001
5 years, 10 months ago (2015-02-03 02:11:54 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (None)
5 years, 10 months ago (2015-02-03 04:12:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895433002/20001
5 years, 10 months ago (2015-02-03 13:34:41 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-03 13:35:32 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 13:36:38 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f575e01d05e216389f358356adcc8c46f23f36d5
Cr-Commit-Position: refs/heads/master@{#314324}

Powered by Google App Engine
This is Rietveld 408576698