Source/core/layout/LayoutThemeChromiumMac.mm - Issue 895383002: Let StyleResolver figure out differences between UA style and resolved style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutThemeChromiumMac.mm

Issue 895383002: Let StyleResolver figure out differences between UA style and resolved style. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/layout/LayoutThemeChromiumMac.h ('k') | Source/core/rendering/style/UAStyleChange.h » ('j') | Source/core/rendering/style/UAStyleChange.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/LayoutThemeChromiumMac.mm

diff --git a/Source/core/layout/LayoutThemeChromiumMac.mm b/Source/core/layout/LayoutThemeChromiumMac.mm

index 66c6dc4b023da4b58883efbad0695b764c872214..a94046cfcc8209be8d169d4fea0f15e0dc9ed900 100644

--- a/Source/core/layout/LayoutThemeChromiumMac.mm

+++ b/Source/core/layout/LayoutThemeChromiumMac.mm

@@ -42,6 +42,7 @@

#import "core/rendering/RenderProgress.h"

#import "core/rendering/RenderView.h"

#import "core/rendering/style/ShadowList.h"

+#import "core/rendering/style/UAStyleChange.h"

#import "platform/LayoutTestSupport.h"

#import "platform/PlatformResourceLoader.h"

#import "platform/SharedBuffer.h"

@@ -469,11 +470,10 @@ Color LayoutThemeChromiumMac::systemColor(CSSValueID cssValueId) const

return color;

}

-bool LayoutThemeChromiumMac::isControlStyled(const RenderStyle* style, const CachedUAStyle* uaStyle) const

+bool LayoutThemeChromiumMac::isControlStyled(const RenderStyle* style, const UAStyleChange& uaStyle) const

{

- ASSERT(uaStyle);

if (style->appearance() == TextFieldPart || style->appearance() == TextAreaPart)

- return style->border() != uaStyle->border || style->boxShadow();

+ return uaStyle.borderChanged || style->boxShadow();

// FIXME: This is horrible, but there is not much else that can be done.

// Menu lists cannot draw properly when scaled. They can't really draw

« no previous file with comments | « Source/core/layout/LayoutThemeChromiumMac.h ('k') | Source/core/rendering/style/UAStyleChange.h » ('j') | Source/core/rendering/style/UAStyleChange.h » ('J')