Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1020)

Issue 895363005: Revert of Split ui/base/ime into a new component (Closed)

Created:
5 years, 10 months ago by ccameron
Modified:
5 years, 10 months ago
Reviewers:
Nico, jam, sky, Yuki, spang
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, yusukes+watch_chromium.org, mlamouri+watch-content_chromium.org, tfarina, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, mkwst+moarreviews-shell_chromium.org, James Su, stevenjb+watch_chromium.org, jochen+watch_chromium.org, yukishiino+watch_chromium.org, Shu Chen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Split ui/base/ime into a new component (patchset #4 id:60001 of https://codereview.chromium.org/889323003/) Reason for revert: Windows builds failing with ERROR at //ui/base/ime/BUILD.gn:170:5: Undefined variable for +=. libs += [ "imm32.lib" ] ^--- I don't have something with this name in scope now. http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/4403/steps/gn/logs/stdio (perhaps missed a .gn update)? Original issue's description: > Split ui/base/ime into a new component > > The IME code in ui/base/ime depends on ui/ozone to support keyboard > control (via the InputController interface). This dependency is > currently missing from the build. > > Unfortunately, we cannot simply add this dependency, because ui/ozone > depends on code from ui/base/cursor and ui/base/resource > (for cursor bitmaps). > > Break this cycle by componentizing ui/base/ime & add a dependency > from the new ui/base/ime component to ui/ozone. > > This also helps clean things up a bit because iOS builds ui/base > but not ui/base/ime. So there is already a fault line here. > > The handful of IME tests are left as part of ui_base_unittests. > > BUG=445627 > TEST=gn gen out_gn_ozone --args='os="chromeos" use_ozone=true is_component_build=true' && > ninja -C out_gn_ozone chrome ozone_unittests (along with other needed changes) > TBR=jam > > Committed: https://crrev.com/2321ca1b99c1a8e9a90e48a9cd50f6446a7e5e82 > Cr-Commit-Position: refs/heads/master@{#314815} TBR=sky@chromium.org,thakis@chromium.org,jam@chromium.org,yukishiino@chromium.org,spang@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=445627 Committed: https://crrev.com/5b27993c4ed9bb439c693b86e7f1190c4d49b6e0 Cr-Commit-Position: refs/heads/master@{#314823}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+381 lines, -584 lines) Patch
M ash/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
M ash/ash.gyp View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/libgtk2ui.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_shell.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 3 chunks +0 lines, -3 lines 0 comments Download
M content/shell/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M extensions/shell/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/shell/app_shell.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/aura/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/aura.gyp View 3 chunks +0 lines, -3 lines 0 comments Download
M ui/base/BUILD.gn View 4 chunks +138 lines, -6 lines 0 comments Download
D ui/base/ime/BUILD.gn View 1 chunk +0 lines, -179 lines 0 comments Download
M ui/base/ime/candidate_window.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/base/ime/chromeos/character_composer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ime/chromeos/component_extension_ime_manager.h View 4 chunks +5 lines, -5 lines 0 comments Download
M ui/base/ime/chromeos/composition_text.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ime/chromeos/extension_ime_util.h View 2 chunks +20 lines, -20 lines 0 comments Download
M ui/base/ime/chromeos/fake_ime_keyboard.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/chromeos/fake_input_method_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ime/chromeos/ime_bridge.h View 5 chunks +5 lines, -5 lines 0 comments Download
M ui/base/ime/chromeos/ime_keyboard.h View 3 chunks +5 lines, -5 lines 0 comments Download
M ui/base/ime/chromeos/ime_keyboard_ozone.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/ime/chromeos/ime_keyboard_x11.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ime/chromeos/ime_keymap.h View 1 chunk +3 lines, -4 lines 0 comments Download
M ui/base/ime/chromeos/input_method_descriptor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ime/chromeos/input_method_manager.h View 3 chunks +5 lines, -5 lines 0 comments Download
M ui/base/ime/chromeos/input_method_whitelist.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/ime/chromeos/mock_component_extension_ime_manager_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ime/chromeos/mock_ime_candidate_window_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ime/chromeos/mock_ime_engine_handler.h View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/base/ime/chromeos/mock_ime_input_context_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ime/composition_text.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ime/composition_text_util_pango.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/ime/dummy_input_method_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/infolist_entry.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ime/input_method_auralinux.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/input_method_base.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/base/ime/input_method_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/input_method_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/ime/input_method_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/base/ime/input_method_initializer.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ui/base/ime/input_method_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/input_method_minimal.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/input_method_observer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ime/input_method_win.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/linux/linux_input_method_context.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/base/ime/linux/linux_input_method_context_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/ime/mock_input_method.h View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/base/ime/remote_input_method_delegate_win.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/ime/remote_input_method_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/base/ime/text_input_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/ime/text_input_focus_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
D ui/base/ime/ui_base_ime.gyp View 1 chunk +0 lines, -186 lines 0 comments Download
D ui/base/ime/ui_base_ime_export.h View 1 chunk +0 lines, -34 lines 0 comments Download
M ui/base/ime/win/imm32_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/ime/win/tsf_input_scope.h View 3 chunks +5 lines, -6 lines 0 comments Download
M ui/base/ui_base.gyp View 5 chunks +122 lines, -3 lines 0 comments Download
M ui/base/ui_base_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/chromeos/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/chromeos/ui_chromeos.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/keyboard/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/keyboard/keyboard.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/views/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
M ui/views/views.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/wm/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/wm/wm.gyp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ccameron
Created Revert of Split ui/base/ime into a new component
5 years, 10 months ago (2015-02-05 16:27:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895363005/1
5 years, 10 months ago (2015-02-05 16:27:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 16:29:03 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 16:29:58 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b27993c4ed9bb439c693b86e7f1190c4d49b6e0
Cr-Commit-Position: refs/heads/master@{#314823}

Powered by Google App Engine
This is Rietveld 408576698