Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 895343004: Add missing ui_base_ime dep to views.gyp:views_test_support (Closed)

Created:
5 years, 10 months ago by tapted
Modified:
5 years, 10 months ago
Reviewers:
tfarina, sky
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing ui_base_ime dep to views.gyp:views_test_support Note ui/views/BUILD.gn actually has it already. views_unittests compile regressed in r314860 It's only a problem for toolkit-views on Mac because it doesn't depend on aura_test_support there (which also has the dependency). views_test_support should have it for the call to ui::{Initialize,Shutdown}InputMethodForTesting() in ViewsTestBase. BUG=378134 Committed: https://crrev.com/a4a99f706707aa7d128930645d94c2190ae766c9 Cr-Commit-Position: refs/heads/master@{#315166}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/views/views.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
tapted
5 years, 10 months ago (2015-02-06 06:46:23 UTC) #2
tfarina
Yep, confirmed. https://chromium.googlesource.com/chromium/src/+/master/ui/views/BUILD.gn#133 lgtm
5 years, 10 months ago (2015-02-06 09:00:42 UTC) #4
sky
LGTM
5 years, 10 months ago (2015-02-06 15:56:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/895343004/1
5 years, 10 months ago (2015-02-07 01:47:54 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-07 02:44:30 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-07 02:45:18 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4a99f706707aa7d128930645d94c2190ae766c9
Cr-Commit-Position: refs/heads/master@{#315166}

Powered by Google App Engine
This is Rietveld 408576698